Re: [PATCH 1/1] linux-firmware: remove hard-coded paths

Phil Blundell
2016-01-05T22:20:42Z

On Tue, 2016-01-05 at 11:06 -0600, Mark Hatle wrote:
> This is a situation where we've got hard coded '/lib' entries in FILES, but
> we're trying to move the directory elsewhere.... 'adjusting' FILES automatically
> is probably more error prone and complicated then desired.. but I'm not sure
> switching to nonarch_baselib_dir is right either.. argh. (But it may certainly
> be the less evil in this case.)

Isn't this more or less exactly what ${nonarch_baselib_dir} is for? If
there's some disconnect between firmware and other users of that
variable (mostly mdev/udev/systemd I guess) then maybe we should
introduce a separate ${firmware_loader_dir} or something. But either
way, it seems fairly clear that the right thing is to simply have a
variable that the distro can set to the right place, and then have both
do_install() and FILES defined in terms of that same variable, rather
than doing some sort of subsequent post-processing step that tries to
move the contents around and then patch FILES up to match.

p.