Re: [PATCH 1/1] linux-firmware: remove hard-coded paths

Mark Hatle
2016-01-04T16:32:24Z

On 1/4/16 10:11 AM, Matthias Schiffer wrote:
> On 01/04/2016 02:14 PM, Ian Ray wrote:
>> The recipe uses hard-coded paths (specifically /lib) in do_install
>> and in FILES, however on a merged /usr system this directory might
>> not exist. Prefer base_libdir.
>>
>> Signed-off-by: Ian Ray <ian.ray@ge.com>
>> ---
>
> This should use nonarch_base_libdir, base_libdir defaults to /lib64 on
> ppc64, which is not where the firmware is expected.
>

At a minimum, I would agree nonarch_base_libdir, however..

I believe that the kernel loader/modules/tools themselves actually have '/lib'
hard coded into them. This is the reason why /lib/firmware was used and not one
of the variables.

This is one of the cases were /lib is actually correct, since that is what the
system is expecting. We can make some kind of accommodation for systems where
/lib -> /usr/lib... but that should be done inside of the filesystem setup
processing and not the package itself. (I'm referring to the
'meta/files/fs-perms.txt' file.

--Mark