From: Haris Okanovic <haris.okanovic@ni.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] tzdata: Make /etc/timezone optional
Date: Tue, 5 Jan 2016 13:03:17 -0600 [thread overview]
Message-ID: <568C1375.6080706@ni.com> (raw)
In-Reply-To: <CAJTo0LaHTkODDiLfOYDQoFC-VBDD5h4XctAidjzRfyYGgdAfKA@mail.gmail.com>
On 01/05/2016 07:03 AM, Burton, Ross wrote:
>
> On 23 December 2015 at 23:51, Haris Okanovic <haris.okanovic@ni.com
> <mailto:haris.okanovic@ni.com>> wrote:
>
> +CONFFILES_${PN} +=
> "${@['','${sysconfdir}/timezone'][d.getVar('INSTALL_TIMEZONE_FILE',
> True) == '1']}"
>
>
> This idiom (indexing an array by a coerced boolean) is pretty difficult
> to read and bitbake has a helper function to turn a string into a bool,
> so I find something like this a lot easier to read:
>
> ${@"${sysconfdir}/timezone" if
> bb.utils.to_boolean(d.getVar("INSTALL_TIMEZONE_FILE", True)) else ""}
>
> (untested!)
I agree the alternative is much easier to read, and verified it works as
expected. Posting V2 shortly.
Thanks for looking into it!
-- Haris
next prev parent reply other threads:[~2016-01-05 19:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 23:51 [PATCH] tzdata: Make /etc/timezone optional Haris Okanovic
2016-01-05 13:03 ` Burton, Ross
2016-01-05 19:03 ` Haris Okanovic [this message]
2016-01-05 19:04 ` [PATCH v2] " Haris Okanovic
2016-01-12 4:03 ` Andre McCurdy
2016-01-12 10:24 ` Burton, Ross
2016-01-12 16:25 ` Haris Okanovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568C1375.6080706@ni.com \
--to=haris.okanovic@ni.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox