From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 174FB65CC2 for ; Mon, 11 Jan 2016 15:06:11 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id u0BF6BiB004374 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Mon, 11 Jan 2016 07:06:11 -0800 (PST) Received: from Marks-MacBook-Pro.local (172.25.36.227) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.248.2; Mon, 11 Jan 2016 07:06:10 -0800 To: Trevor Woerner , Robert Yang , References: <4f5f10ebe2593fb40fbb637978480d87d9697f40.1452489034.git.liezhi.yang@windriver.com> <5693C245.7060304@gmail.com> From: Mark Hatle Organization: Wind River Systems Message-ID: <5693C4EE.4040507@windriver.com> Date: Mon, 11 Jan 2016 09:06:22 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <5693C245.7060304@gmail.com> Subject: Re: [PATCH 1/2] glibc-initial.inc: use relative path to run configure X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2016 15:06:12 -0000 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit On 1/11/16 8:55 AM, Trevor Woerner wrote: > > > On 01/11/16 00:11, Robert Yang wrote: >> Avoid potential build path in output files. >> >> [YOCTO #8894] >> >> Signed-off-by: Robert Yang >> --- >> meta/recipes-core/glibc/glibc-initial.inc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/recipes-core/glibc/glibc-initial.inc b/meta/recipes-core/glibc/glibc-initial.inc >> index 8e81f09..cb2f8dd 100644 >> --- a/meta/recipes-core/glibc/glibc-initial.inc >> +++ b/meta/recipes-core/glibc/glibc-initial.inc >> @@ -11,7 +11,7 @@ TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_TCBOOTSTRAP}" >> do_configure () { >> (cd ${S} && gnu-configize) || die "failure in running gnu-configize" >> find ${S} -name "configure" | xargs touch >> - ${S}/configure --host=${TARGET_SYS} --build=${BUILD_SYS} \ >> + ../git/configure --host=${TARGET_SYS} --build=${BUILD_SYS} \ > > Although I haven't tested it, this _looks_ like it might fail quite > readily. I'm sure there are some recipes that play tricks with ${S}, and > what about recipes that don't pull their sources from git? > > Maybe something like: (cd ${S} && ./configure ...) would be better? That won't work since it'll run configure in the S directory. IF we need to use relative paths here, we need to calculate the relative path from B to S and use that. It looks like patch 2/2 already does something like this using the python.. we can probably do the same. (I don't know any reason, at least for glibc, that all of the items won't be in the same "WORKDIR". So it would be relative within the WORKDIR, which SHOULD be fine.) >> --prefix=/usr \ >> --without-cvs --disable-sanity-checks \ >> --with-headers=${STAGING_DIR_TARGET}${includedir} \ >