Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Jian Liu <jian.liu@windriver.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: Bruce Ashfield <bruce.ashfield@windriver.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] linux-libc-headers: set ALLOW_EMPTY
Date: Wed, 20 Jan 2016 13:42:25 +0800	[thread overview]
Message-ID: <569F1E41.2090509@windriver.com> (raw)
In-Reply-To: <20160119113742.GB2611@jama>



On 2016年01月19日 19:37, Martin Jansa wrote:
> On Tue, Jan 19, 2016 at 11:12:18AM +0800, Jian Liu wrote:
>>
>> On 2016年01月16日 02:17, Richard Purdie wrote:
>>> On Thu, 2016-01-14 at 14:46 +0800, Jian Liu wrote:
>>>> If setting IMAGE_INSTALL += "linux-libc-headers", do_rootfs will
>>>> cause
>>>> error.
>>>>     ERROR: linux-libc-headers not found in the base feeds
>>>>
>>>> This is because that there is no linux-libc-headers.rpm generated.
>>> There is no point in generating an empty package just for the sake of
>>> it. Surely you just shouldn't put that in IMAGE_INSTALL?
>>>
>>> Cheers,
>>>
>>> Richard
>> Yes, I submit this patch just considering that someone who is not
>> familiar with yocto may be confused
>> by this behavior. There is linux-libc-headers bb file so IMAGE_INSTALL
>> += "linux-libc-headers" is taken for
>> granted.
>>
>> This is really not a bug and it is just a usage problem.
> And you're making it worse, by allowing such person to install
> completely useless empty package assuming that (s)he installed
> linux-libc-headers to the image.
>
> Error message is _much_ better than empty useless package.
I understand. Thanks a lot.

>
>>>> diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc
>>>> -headers.inc b/meta/recipes-kernel/linux-libc-headers/linux-libc
>>>> -headers.inc
>>>> index 2ba6ed5..403360b 100644
>>>> --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
>>>> +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers.inc
>>>> @@ -76,3 +76,5 @@ RRECOMMENDS_${PN}-dbg = "${PN}-dev (=
>>>> ${EXTENDPKGV})"
>>>>    
>>>>    INHIBIT_DEFAULT_DEPS = "1"
>>>>    DEPENDS += "unifdef-native"
>>>> +
>>>> +ALLOW_EMPTY_${PN} = "1"
>> -- 
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core



      reply	other threads:[~2016-01-20  5:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-14  6:46 [PATCH 1/1] linux-libc-headers: set ALLOW_EMPTY Jian Liu
2016-01-15 18:17 ` Richard Purdie
2016-01-15 18:30   ` Bruce Ashfield
2016-01-19  3:12   ` Jian Liu
2016-01-19 11:37     ` Martin Jansa
2016-01-20  5:42       ` Jian Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569F1E41.2090509@windriver.com \
    --to=jian.liu@windriver.com \
    --cc=bruce.ashfield@windriver.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox