Re: [PATCH] stress-ng: add 0.05.09

[Mike Looijmans <mike.looijmans@topic.nl>]

On 26-01-16 05:36, Robert Yang wrote:
>
>
> On 01/26/2016 11:34 AM, Denys Dmytriyenko wrote:
>> From: Denys Dmytriyenko <denys@ti.com>
>>
>> A clean room re-implementation and extension of the original stress tool.
>>
>> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>> ---
>>   meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>   create mode 100644 meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>>
>> diff --git a/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>> b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>> new file mode 100644
>> index 0000000..2e92c53
>> --- /dev/null
>> +++ b/meta/recipes-extended/stress-ng/stress-ng_0.05.09.bb
>> @@ -0,0 +1,15 @@
>> +SUMMARY = "A tool to load and stress a computer system"
>> +HOMEPAGE = "http://kernel.ubuntu.com/~cking/stress-ng/"
>> +LICENSE = "GPLv2"
>> +LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
>> +
>> +SRC_URI = "http://kernel.ubuntu.com/~cking/tarballs/${BPN}/${BP}.tar.gz"
>> +
>> +SRC_URI[md5sum] = "fe65047991f654ffaac3c59ea9537763"
>> +SRC_URI[sha256sum] =
>> "d785b5f2df042d42c43ddfd5bbafa19151ed96f0c483d7f44c737f492b52ddd6"
>> +
>> +CFLAGS += "-Wall -Wextra -DVERSION='"$(VERSION)"' -O2"
>
> Why hardcode -O2, please ? It impacts the DEBUG_BUILD.

And while your at it, why force-feed "-Wall -Wextra" to the compiler? It will 
just make the compilation take longer and generate a bigger log file that no 
one will ever read, but it won't make a difference in the output.

>
> // Robert
>
>> +
>> +do_install() {
>> +    oe_runmake DESTDIR=${D} install
>> +}
>>



Kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Products
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: +31 (0) 499 33 69 79
E-mail: mike.looijmans@topicproducts.com
Website: www.topicproducts.com

Please consider the environment before printing this e-mail

Visit us at: Embedded World 2016 Germany, Hall 1, stand number 220.
Click here to schedule an appointment with us at Embedded World, free ticket included

http://topicembeddedproducts.com/schedule-an-appointment/