From: Randy MacLeod <randy.macleod@windriver.com>
To: Andre McCurdy <armccurdy@gmail.com>,
<openembedded-core@lists.openembedded.org>,
"Huang, Jie (Jackie)" <Jackie.Huang@windriver.com>
Subject: Re: [PATCH 2/3] glib-2.0: drop add-march-i486-into-CFLAGS-automatically.patch
Date: Mon, 1 Feb 2016 17:23:01 -0500 [thread overview]
Message-ID: <56AFDAC5.9000008@windriver.com> (raw)
In-Reply-To: <1453937316-1311-3-git-send-email-armccurdy@gmail.com>
On 2016-01-27 06:28 PM, Andre McCurdy wrote:
> The reasoning behind this patch isn't clear. ${CC} should always
> contain appropriate -march flags. If the build is misconfigured
> somehow (or someone is trying to build for i386) then we want the
> configure scipt to generate an error, not to try to quietly try to
> fix it (adding -march=i486 to CFLAGS is potentially going to cause
> more problems than it solves).
>
> Since this patch is unlikely to ever be merged upstream and it's not
> helpful in any typical OE build, drop it rather than maintaining it.
>
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Jackie,
Do you remember why this patch was needed?
--
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON,
Canada, K2K 2W5
next prev parent reply other threads:[~2016-02-01 22:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 23:28 [PATCH 0/3] glib-2.0: minor fixes and updates Andre McCurdy
2016-01-27 23:28 ` [PATCH 1/3] glib-2.0: refresh configure-libtool.patch Andre McCurdy
2016-01-27 23:28 ` [PATCH 2/3] glib-2.0: drop add-march-i486-into-CFLAGS-automatically.patch Andre McCurdy
2016-02-01 22:23 ` Randy MacLeod [this message]
2016-02-01 22:44 ` Phil Blundell
2016-02-03 8:07 ` Huang, Jie (Jackie)
2016-01-27 23:28 ` [PATCH 3/3] glib.inc: limit ARM_INSTRUCTION_SET over-rides to armv4/armv5 Andre McCurdy
2016-03-03 13:02 ` Phil Blundell
2016-03-03 13:18 ` Martin Jansa
2016-03-03 14:00 ` Phil Blundell
2016-03-03 19:11 ` Andre McCurdy
2016-03-03 19:30 ` Phil Blundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AFDAC5.9000008@windriver.com \
--to=randy.macleod@windriver.com \
--cc=Jackie.Huang@windriver.com \
--cc=armccurdy@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox