From: "Aníbal Limón" <anibal.limon@linux.intel.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org,
benjamin.esquivel@intel.com,
"Aníbal Limón" <limon.anibal@gmail.com>
Subject: Re: [PATCH 13/20] oeqa/oetest.py: Fix missing oeqa.runtime import.
Date: Tue, 2 Feb 2016 15:31:06 -0600 [thread overview]
Message-ID: <56B1201A.8080602@linux.intel.com> (raw)
In-Reply-To: <1693758.K4BiiZTEt9@peggleto-mobl.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1036 bytes --]
Yes, but i think is better to import only the module that we need. :)
On 02/02/2016 03:25 PM, Paul Eggleton wrote:
> On Tue, 02 Feb 2016 09:14:16 Aníbal Limón wrote:
>> From: Aníbal Limón <limon.anibal@gmail.com>
>>
>> oeqa.runtime import is used in TestContext to get data fixtures
>> directory.
>>
>> Signed-off-by: Aníbal Limón <limon.anibal@gmail.com>
>> ---
>> meta/lib/oeqa/oetest.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/lib/oeqa/oetest.py b/meta/lib/oeqa/oetest.py
>> index 28577ef..16705cc 100644
>> --- a/meta/lib/oeqa/oetest.py
>> +++ b/meta/lib/oeqa/oetest.py
>> @@ -18,7 +18,7 @@ except ImportError:
>> pass
>> import logging
>>
>> -import oeqa
>> +import oeqa.runtime
>> from oeqa.utils.decorators import LogResults, gettag, getResults
>>
>> logger = logging.getLogger("BitBake")
>
> Are you sure this actually does anything? Importing the parent module should
> already allow access to child modules, AIUI.
>
> Cheers,
> Paul
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2016-02-02 21:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 15:14 [PATCH 00/20] Add Extensible SDK test suite Aníbal Limón
2016-02-02 15:14 ` [PATCH 01/20] testimage: Modularize helper functions for get test lists Aníbal Limón
2016-02-02 15:14 ` [PATCH 02/20] classes/testsdk: Add new class testsdk Aníbal Limón
2016-02-02 15:14 ` [PATCH 03/20] classes/testimage: Add defeault inherit for testsdk Aníbal Limón
2016-02-02 15:14 ` [PATCH 04/20] populate_sdk_ext: Set TOOLCHAINEXT_OUTPUTNAME Aníbal Limón
2016-02-02 15:14 ` [PATCH 05/20] get_test_suites: Add sdkext type for load test suites Aníbal Limón
2016-02-02 15:14 ` [PATCH 06/20] classes/testsdk: Add testsdkext task only install Aníbal Limón
2016-02-02 15:14 ` [PATCH 07/20] bb/fetch2: Move export_proxies function from wget to utils Aníbal Limón
2016-02-02 15:14 ` [PATCH 08/20] classes/testsdk: Add call to export_proxies on testsdkext Aníbal Limón
2016-02-02 15:14 ` [PATCH 09/20] toolchain-shar-extract.sh: Add proxy variable to new env Aníbal Limón
2016-02-02 15:14 ` [PATCH 10/20] testimage/testsdk: Modularize TestContext Aníbal Limón
2016-02-02 15:14 ` [PATCH 11/20] testimage/testsdk: Move get test suites routine inside TestContext Aníbal Limón
2016-02-02 15:14 ` [PATCH 12/20] oetest.py/TestContext: Move loadTests and runTests inside it Aníbal Limón
2016-02-02 15:14 ` [PATCH 13/20] oeqa/oetest.py: Fix missing oeqa.runtime import Aníbal Limón
2016-02-02 21:25 ` Paul Eggleton
2016-02-02 21:31 ` Aníbal Limón [this message]
2016-02-02 21:32 ` Paul Eggleton
2016-02-02 15:14 ` [PATCH 14/20] classes/testsdk: Add function run_test_context Aníbal Limón
2016-02-02 15:14 ` [PATCH 15/20] classes/populate_sdk_ext: Add OE_SDK_EXT_SILENT env variable Aníbal Limón
2016-02-02 21:19 ` Paul Eggleton
2016-02-02 21:23 ` Aníbal Limón
2016-02-02 21:25 ` Paul Eggleton
2016-02-02 21:30 ` Aníbal Limón
2016-02-02 21:31 ` Paul Eggleton
2016-02-02 21:38 ` Aníbal Limón
2016-02-02 21:40 ` Paul Eggleton
2016-02-02 21:47 ` Aníbal Limón
2016-02-02 21:49 ` Paul Eggleton
2016-02-02 15:14 ` [PATCH 16/20] classes/testsdk: Add compatibility SDK testsuite to eSDK Aníbal Limón
2016-02-02 15:14 ` [PATCH 17/20] testsdkext: Add skeleton for support Extensible SDK tests Aníbal Limón
2016-02-02 15:14 ` [PATCH 18/20] classes/populate_sdk_ext: Add SDK_EXT_TARGET_MANIFEST and SDK_EXT_HOST_MANIFEST Aníbal Limón
2016-02-02 21:52 ` Paul Eggleton
2016-02-02 22:05 ` Aníbal Limón
2016-02-02 22:06 ` Paul Eggleton
2016-02-02 22:13 ` Aníbal Limón
2016-02-02 22:15 ` Paul Eggleton
2016-02-02 15:14 ` [PATCH 19/20] oeqa/sdkext: Add devtool basic tests for eSDK Aníbal Limón
2016-02-02 22:03 ` Paul Eggleton
2016-02-02 22:14 ` Aníbal Limón
2016-02-02 15:14 ` [PATCH 20/20] classes/testsdk: Add help information on how to run tests Aníbal Limón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B1201A.8080602@linux.intel.com \
--to=anibal.limon@linux.intel.com \
--cc=benjamin.esquivel@intel.com \
--cc=limon.anibal@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox