From: "Aníbal Limón" <anibal.limon@linux.intel.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: benjamin.esquivel@intel.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 21/21] classes/testimage: Fix exportTests function.
Date: Tue, 2 Feb 2016 16:33:06 -0600 [thread overview]
Message-ID: <56B12EA2.5040807@linux.intel.com> (raw)
In-Reply-To: <1500430.HvkegzEm32@peggleto-mobl.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]
On 02/02/2016 04:30 PM, Paul Eggleton wrote:
> On Tue, 02 Feb 2016 12:09:37 Aníbal Limón wrote:
>> With new structure of TestContext now holds suite and variable
>> that contains unittest instances, it can't be exported using
>> JSON causing and exception.
>>
>> Adds the suite variable for avoid export it.
>>
>> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
>> ---
>> meta/classes/testimage.bbclass | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/classes/testimage.bbclass b/meta/classes/testimage.bbclass
>> index 5fafda1..57858e6 100644
>> --- a/meta/classes/testimage.bbclass
>> +++ b/meta/classes/testimage.bbclass
>> @@ -112,7 +112,7 @@ def exportTests(d,tc):
>> savedata["host_dumper"] = {}
>> for key in tc.__dict__:
>> # special cases
>> - if key != "d" and key != "target" and key != "host_dumper":
>> + if key != "d" and key != "target" and key != "host_dumper" and key
>> != "suite": savedata[key] = getattr(tc, key)
>
> Given how long this is getting we might want to change to:
>
> if key not in ['d', 'target', 'host_dumper', 'suite']:
Good one...
>
> Cheers,
> Paul
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2016-02-02 22:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1454436558.git.anibal.limon@linux.intel.com>
2016-02-02 18:09 ` [PATCH 21/21] classes/testimage: Fix exportTests function Aníbal Limón
2016-02-02 22:30 ` Paul Eggleton
2016-02-02 22:33 ` Aníbal Limón [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B12EA2.5040807@linux.intel.com \
--to=anibal.limon@linux.intel.com \
--cc=benjamin.esquivel@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox