From: "Aníbal Limón" <anibal.limon@linux.intel.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>,
richard.purdie@linuxfoundation.org, benjamin.esquivel@intel.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2 23/28] Revert "classes/populate_sdk_ext: Add OE_SDK_EXT_SILENT env variable"
Date: Thu, 4 Feb 2016 14:38:56 -0600 [thread overview]
Message-ID: <56B3B6E0.4000309@linux.intel.com> (raw)
In-Reply-To: <4933227.rYH5s4XHH6@peggleto-mobl.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]
Comments below,
On 02/04/2016 02:19 PM, Paul Eggleton wrote:
> On Thu, 04 Feb 2016 14:12:40 Aníbal Limón wrote:
>> On 02/04/2016 12:34 PM, Paul Eggleton wrote:
>>> On Tue, 02 Feb 2016 18:30:35 Aníbal Limón wrote:
>>>> This reverts commit 303985d3f402013c7c4a3355f19d48b1cef1c12f.
>>>>
>>>> As discussion with Paul Eggleton, he don't want to have env variables
>>>> to change the behaviour of what the env script needs to print,
>>>> i'll redirect the output in oeSDK.run() method.
>>>>
>>>> I didn't agree because it can hides another messages like error ones
>>>> and with the variable you can control what prints or not.
>>>>
>>>> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
>>>
>>> We don't want to add this and revert it in the same series.
>>
>> Ok, then i'll send another series without this commit and this revert in
>> another commit.
>
> If you mean without both the commit and the revert, then yes.
>
No i don't mean that way because i don't agree with this change and i
consider this as *CENSURE* because if i someone don't agree a change the
why? information need to be placed in the git repository for future
references.
I'll make the changes that you requested to drop the two commits (i'm
still disagree) for don't stop the process of integrate the eSDK tests
that we need for a some time ago.
Cheers,
alimon
> Cheers,
> Paul
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2016-02-04 20:36 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 0:30 [PATCH v2 00/28] Add Extensible SDK test suite Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 01/28] testimage: Modularize helper functions for get test lists Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 02/28] classes/testsdk: Add new class testsdk Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 03/28] classes/testimage: Add defeault inherit for testsdk Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 04/28] populate_sdk_ext: Set TOOLCHAINEXT_OUTPUTNAME Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 05/28] get_test_suites: Add sdkext type for load test suites Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 06/28] classes/testsdk: Add testsdkext task only install Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 07/28] bb/fetch2: Move export_proxies function from wget to utils Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 08/28] classes/testsdk: Add call to export_proxies on testsdkext Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 09/28] toolchain-shar-extract.sh: Add proxy variable to new env Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 10/28] testimage/testsdk: Modularize TestContext Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 11/28] testimage/testsdk: Move get test suites routine inside TestContext Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 12/28] oetest.py/TestContext: Move loadTests and runTests inside it Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 13/28] oeqa/oetest.py: Fix missing oeqa.runtime import Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 14/28] classes/testsdk: Add function run_test_context Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 15/28] classes/populate_sdk_ext: Add OE_SDK_EXT_SILENT env variable Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 16/28] classes/testsdk: Add compatibility SDK testsuite to eSDK Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 17/28] testsdkext: Add skeleton for support Extensible SDK tests Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 18/28] classes/populate_sdk_ext: Add SDK_EXT_TARGET_MANIFEST and SDK_EXT_HOST_MANIFEST Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 19/28] oeqa/sdkext: Add devtool basic tests for eSDK Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 20/28] classes/testsdk: Add help information on how to run tests Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 21/28] classes/testimage: Fix exportTests function Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 22/28] oeqa/sdkext/devtool.py: Add location test to ensure that devtool is the eSDK one Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 23/28] Revert "classes/populate_sdk_ext: Add OE_SDK_EXT_SILENT env variable" Aníbal Limón
2016-02-04 18:34 ` Paul Eggleton
2016-02-04 20:12 ` Aníbal Limón
2016-02-04 20:19 ` Paul Eggleton
2016-02-04 20:38 ` Aníbal Limón [this message]
2016-02-04 20:40 ` Paul Eggleton
2016-02-04 20:47 ` Richard Purdie
2016-02-04 20:53 ` Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 24/28] oeqa/oetest: oeSDKTest when run a command redirect env output to null Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 25/28] oeqa/oetest.py: SDK{Ext, } improve host and target manifest load Aníbal Limón
2016-02-04 18:35 ` Paul Eggleton
2016-02-04 20:13 ` Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 26/28] oeqa/oetest: Fix compatibility SDK tests using eSDK Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 27/28] classes/testimage: exportTests simple improvment to use list instead of test expresions Aníbal Limón
2016-02-04 18:34 ` Paul Eggleton
2016-02-04 20:13 ` Aníbal Limón
2016-02-03 0:30 ` [PATCH v2 28/28] classes/test{image, sdk}: Update Copyrights to match the true dates Aníbal Limón
2016-02-04 18:34 ` Paul Eggleton
2016-02-04 20:13 ` Aníbal Limón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B3B6E0.4000309@linux.intel.com \
--to=anibal.limon@linux.intel.com \
--cc=benjamin.esquivel@intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox