Re: [PATCH V2 2/7] binutils: Repair nios2 PLT and GP handling

[Randy MacLeod <randy.macleod@windriver.com>]

On 2016-02-09 09:29 AM, Marek Vasut wrote:
> On Tuesday, February 09, 2016 at 03:21:17 PM, Burton, Ross wrote:
>> On 9 February 2016 at 13:08, Marek Vasut <marex@denx.de> wrote:
>>> Repair corner cases in nios2 PLT and GP handling. See the patches
>>> themselves for extensive detailed explanation.

This sentence doesn't really add much value since many patches
contain additional description and the logs here are mostly a
few lines from the ChangeLog which doesn't count as an extensive
detailed explanation in my books. :)

I expect that you're familiar with this but take a look at:
http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded#Committing_your_patch

     Commit with a concise and descriptive message -
     one that explains your changes in a way others get
     a short overview without looking at the code.

>>>
>>> The patches don't contain the ChangeLog entries, since the changelog
>>> entries often cause trouble when applying the patch.

I'd prefer to see the ChangeLog snippets duplicated in the git log
so that it's easier to see what happened.

If you do a v2, please also mention that the patches are backports
since that's important to people when they consider whether the patch
should be accepted.

Thanks!

-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, 
Canada, K2K 2W5