Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [RFC][PATCH] Resolve an issue when using pipes to process data
Date: Tue, 9 Feb 2016 10:25:14 -0600	[thread overview]
Message-ID: <56BA12EA.20104@windriver.com> (raw)
In-Reply-To: <1455032462-124215-1-git-send-email-mark.hatle@windriver.com>

(Had someone ask me where the patch is..)

Our wonderful corporate mail server sucks.. so the thread didn't get attached
with the patch.

This is the cover letter, the patch has the subject:
[RFC][PATCH] buildhistory.bbclass: Break up the find to catch failures

--Mark

On 2/9/16 9:41 AM, Mark Hatle wrote:
> I'm sending this as an RFC.  I know the patch works, but I think it highlights
> a potentially larger issue in the system.
> 
> If we're processing data using shell pipes, the return code of a failed
> process may end up being lost -- avoiding the regular error capture when
> bitbake runs a task.
> 
> In this particular case, while working to fix a bug in pseudo we made an
> error condition fatal (triggered an abort()), but buildhistory kept on
> processing ignoring any issues had occurred.
> 
> Breaking up the processing into steps, things that 'could fail', and later
> processing steps that shouldn't fail will give us more of an opportunity to
> identify failures in the future and deal with them in a quicker manner,
> then having to investigate log files for messages.
> 
> I'm suspecting we should run a janitor exercise against oe-core looking for
> similar situations where we might be piping the data and potentially losing
> return codes in the process.
> 
> Comments?
> 
> Mark Hatle (1):
>   buildhistory.bbclass: Break up the find to catch failures
> 
>  meta/classes/buildhistory.bbclass | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 



  reply	other threads:[~2016-02-09 16:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 15:41 [RFC][PATCH] Resolve an issue when using pipes to process data Mark Hatle
2016-02-09 16:25 ` Mark Hatle [this message]
2016-02-11 16:00 ` Christopher Larson
2016-02-11 16:57 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BA12EA.20104@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox