On 2016年02月16日 20:09, Burton, Ross wrote:
>
> On 16 February 2016 at 07:14, <kai.kang@windriver.com 
> <mailto:kai.kang@windriver.com>> wrote:
>
>     +FLOCK_FILE=$SYSROOT/etc
>
>
> useradd_base is also used by extrausers.bbclass, so it would be best 
> if useradd_base decided where to use as a lock ($rootdir/${sysconfdir} 
> sounds sensible) instead of expecting that the caller sets FLOCK_FILE 
> and mysteriously failing if it wasn't set.

OK. Sounds good.

>
> Also if we're locking and waiting properly instead of using timeouts 
> and loops, can we remove the "does it exist?" check before the 
> operation (eg groupadd -f will exit 0 if the group exists) and after 
> (with proper locking that shouldn't be happening).

I prefer to keep such check. There is more than one case that causes 
operation error such as pass wrong parameters. The messages are helpful 
for developers.

Thanks,
Kai

>
> Ross


-- 
Regards,
Neil | Kai Kang