From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mail.openembedded.org (Postfix) with ESMTP id 1103E766EB for ; Fri, 19 Feb 2016 04:34:51 +0000 (UTC) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 18 Feb 2016 20:34:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,468,1449561600"; d="scan'208";a="889267541" Received: from bitbang.jf.intel.com (HELO [10.7.199.151]) ([10.7.199.151]) by orsmga001.jf.intel.com with ESMTP; 18 Feb 2016 20:34:52 -0800 To: Richard Purdie , openembedded-core@lists.openembedded.org References: <941d876fe835bc1aa26039d0edec9573d482bca3.1455815778.git.randy.e.witt@linux.intel.com> <1455836234.28376.100.camel@linuxfoundation.org> From: Randy Witt Message-ID: <56C69B6C.6010606@linux.intel.com> Date: Thu, 18 Feb 2016 20:34:52 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1455836234.28376.100.camel@linuxfoundation.org> Subject: Re: [PATCH 3/3] populate_sdk_ext.bbclass: Add SDK_RECRDEP_TASKS variable X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 04:34:53 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 02/18/2016 02:57 PM, Richard Purdie wrote: > On Thu, 2016-02-18 at 09:17 -0800, Randy Witt wrote: >> Currently there isn't a way for the extensible sdk to know all the >> tasks >> that will need sstate for an image. This is because a layer can add >> it's >> on custom tasks that are required for an image to be generated. >> >> The extensible sdk solved this for poky by using recrdeptask and >> specifying the tasks known to be required for the image as well as >> for >> building new recipes. >> >> So the SDK_RECRDEP_TASKS variable allows a user to specify additional >> tasks that need to be pulled in. >> >> Signed-off-by: Randy Witt >> --- >> meta/classes/populate_sdk_ext.bbclass | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta/classes/populate_sdk_ext.bbclass >> b/meta/classes/populate_sdk_ext.bbclass >> index 7c95301..5f90aea 100644 >> --- a/meta/classes/populate_sdk_ext.bbclass >> +++ b/meta/classes/populate_sdk_ext.bbclass >> @@ -359,7 +359,7 @@ addtask sdk_depends >> do_sdk_depends[dirs] = "${WORKDIR}" >> do_sdk_depends[depends] = "${@get_ext_sdk_depends(d)}" >> do_sdk_depends[recrdeptask] = "${@d.getVarFlag('do_populate_sdk', >> 'recrdeptask', False)}" >> -do_sdk_depends[recrdeptask] += "do_populate_lic do_package_qa >> do_populate_sysroot do_deploy" >> +do_sdk_depends[recrdeptask] += "do_populate_lic do_package_qa >> do_populate_sysroot do_deploy ${SDK_RECRDEP_TASKS}" >> do_sdk_depends[rdepends] = "${@get_sdk_ext_rdepends(d)}" >> >> def get_sdk_ext_rdepends(d): > > Doesn't this need a default value or it will throw parse failures? Actually, it didn't generate parse errors. My guess is it just didn't expand it and put a bogus task in the list. So I'll send a v2. > > Cheers, > > Richard >