On 2016年02月24日 01:10, Burton, Ross wrote:

On 23 February 2016 at 17:01, Burton, Ross <ross.burton@intel.com> wrote:

The *amazing* BB_VERBOSE_LOGS option (set to 1 in local.conf to get all shell scripts to do set -x) tells me this is due to missing quotes around the opts assignment:

Why do some of the opts assignments just do opts=$2, and others do a sed?

In the previous version, there are:

local opts="$2"
...

opts=`echo $opts | sed s/\'/\"/g`

And I want to refactor them but lost the double quotes.

Only do sed operations for useradd and groupadd that they may be passed in "opts" with space but others didn't.

I'll restore to previous version.

Sorry for inconvenience that I built pass on Ubuntu 14.04 so didn't find this error.

--Kai

Ross

-- 
Regards,
Neil | Kai Kang