From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id B1AB2771EA for ; Wed, 24 Feb 2016 08:51:21 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id u1O8pFtp023385 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 24 Feb 2016 00:51:15 -0800 (PST) Received: from [128.224.162.231] (128.224.162.231) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.3.248.2; Wed, 24 Feb 2016 00:51:14 -0800 To: "Burton, Ross" References: <72d89d471771ecffc8eecc923581d3dcdcfdfa5e.1456195451.git.kai.kang@windriver.com> From: Kang Kai Message-ID: <56CD6F00.3060402@windriver.com> Date: Wed, 24 Feb 2016 16:51:12 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Cc: OE-core Subject: Re: [PATCH 1/1] useradd_base.bbclass: fix simultaneous with flock X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 08:51:23 -0000 Content-Type: multipart/alternative; boundary="------------040603000701030908010108" --------------040603000701030908010108 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit On 2016年02月24日 01:10, Burton, Ross wrote: > > On 23 February 2016 at 17:01, Burton, Ross > wrote: > > The *amazing* BB_VERBOSE_LOGS option (set to 1 in local.conf to > get all shell scripts to do set -x) tells me this is due to > missing quotes around the opts assignment: > > > Why do some of the opts assignments just do opts=$2, and others do a sed? In the previous version, there are: local opts="$2" ... opts=`echo $opts | sed s/\'/\"/g` And I want to refactor them but lost the double quotes. Only do sed operations for useradd and groupadd that they may be passed in "opts" with space but others didn't. I'll restore to previous version. Sorry for inconvenience that I built pass on Ubuntu 14.04 so didn't find this error. --Kai > > Ross -- Regards, Neil | Kai Kang --------------040603000701030908010108 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
On 2016年02月24日 01:10, Burton, Ross wrote:

On 23 February 2016 at 17:01, Burton, Ross <ross.burton@intel.com> wrote:
The *amazing* BB_VERBOSE_LOGS option (set to 1 in local.conf to get all shell scripts to do set -x) tells me this is due to missing quotes around the opts assignment:

Why do some of the opts assignments just do opts=$2, and others do a sed?

In the previous version, there are:

local opts="$2"
...
opts=`echo $opts | sed s/\'/\"/g`

And I want to refactor them but lost the double quotes.

Only do sed operations for useradd and groupadd that they may be passed in "opts" with space but others didn't.

I'll restore to previous version.
Sorry for inconvenience that I built pass on Ubuntu 14.04 so didn't find this error.

--Kai


Ross


-- 
Regards,
Neil | Kai Kang
--------------040603000701030908010108--