Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] base.bbclass wipe ${S} before unpacking source
Date: Fri, 4 Mar 2016 11:17:32 +0100	[thread overview]
Message-ID: <56D960BC.5070800@topic.nl> (raw)
In-Reply-To: <1456227383-9212-2-git-send-email-markus.lehtonen@linux.intel.com>

You might want to assure that S is a child of WORKDIR before wiping it. 
Strange things would happen if someone tried setting S=$HOME in a recipe 
(by mistake or just for experimenting).


On 23-02-16 12:36, Markus Lehtonen wrote:
> Make sure that we have a pristine source tree after do_unpack.
>
> [YOCTO #9064]
>
> Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
> ---
>   meta/classes/base.bbclass | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)

...

-- 
Mike Looijmans


  parent reply	other threads:[~2016-03-04 10:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-23 11:36 [PATCH] Wipe ${S} before unpacking sources Markus Lehtonen
2016-02-23 11:36 ` [PATCH] base.bbclass wipe ${S} before unpacking source Markus Lehtonen
2016-02-23 13:54   ` Burton, Ross
2016-02-23 18:01     ` Christopher Larson
2016-02-23 18:23       ` Burton, Ross
2016-02-24  9:59         ` Markus Lehtonen
2016-03-04 10:17   ` Mike Looijmans [this message]
2016-03-04 15:17 ` [PATCH] Wipe ${S} before unpacking sources Petter Mabäcker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D960BC.5070800@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox