From: Hongxu Jia <hongxu.jia@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 18/18] gconf: fix buildpaths QA issue
Date: Tue, 22 Mar 2016 09:16:09 +0800 [thread overview]
Message-ID: <56F09CD9.7020802@windriver.com> (raw)
In-Reply-To: <CAJTo0LbbXz4PkHzW97csmTBjnffFJwJnR6JauecLrXc-nH3_BQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2140 bytes --]
On 03/21/2016 10:47 PM, Burton, Ross wrote:
>
> On 19 March 2016 at 14:56, Hongxu Jia <hongxu.jia@windriver.com
> <mailto:hongxu.jia@windriver.com>> wrote:
>
> +PACKAGECONFIG[debug] = "--enable-debug=yes, --enable-debug=no"
>
>
> There's an explicit --enable-debug in EXTRA_OECONF,
Yes, we should remove the duplicated --enable-debug in EXTRA_OECONF
> and reading the configure --help shows that the "off" mode should be
> --enable-debug=minimum as "no" removes the GLib checks which can
> result in crashes if bad data is passed to the API.
./configure --help
...
--enable-debug Compile with debug checks. [no/yes/minimum,
default=minimum]
...
vim ./configure.ac
...
121 dnl Default to debug spew in unstable branch
122 AC_ARG_ENABLE(debug,
123 AS_HELP_STRING([--enable-debug],
124 [Compile with debug checks. @<:@no/yes/minimum,
default=minimum@:>@]),
125 , enable_debug=minimum)
126
127 if test "x$enable_debug" = "xyes"; then
128 CFLAGS="$CFLAGS -DGCONF_ENABLE_DEBUG=1"
129 AC_MSG_NOTICE([Will build with debugging spew and checks])
130 else
131 if test "x$enable_debug" = "xno"; then
132 CFLAGS="$CFLAGS -DG_DISABLE_CHECKS=1 -DG_DISABLE_ASSERT=1"
133 AC_MSG_NOTICE([Will build without *any* debugging code])
134 else
135 AC_MSG_NOTICE([Will build with debug checks but no debug spew])
136 fi
137 fi
...
vim gconf/gconfd.c
...
384 #ifdef GCONF_ENABLE_DEBUG
385 /* -- Debug only */
386
387 if (addresses == NULL)
388 {
389 gconf_log(GCL_DEBUG, _("gconfd compiled with debugging;
trying to load gconf.path from the source directory"));
390 conffile = g_strconcat(GCONF_SRCDIR, "/gconf/gconf.path", NULL);
391 addresses = gconf_load_source_path(conffile, NULL);
392 g_free(conffile);
393 }
394
395 /* -- End of Debug Only */
396 #endif
...
If we could not use '--enable-debug=yes' to fix build paths issue,
and as your suggested it should not remove check and assert,
so minimum is the best choice.
//Hongxu
>
> Ross
[-- Attachment #2: Type: text/html, Size: 4166 bytes --]
prev parent reply other threads:[~2016-03-22 1:16 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 9:01 [PATCH V3 00/18] fix buildpaths QA issue Hongxu Jia
2016-03-18 9:01 ` [PATCH 01/18] gcc-5.3/gcc-4.9:replace build path with target path in __FILE__ Hongxu Jia
2016-03-18 9:01 ` [PATCH 02/18] gcc-5.3/gcc-4.9:Reuse -fdebug-prefix-map to replace -ffile-prefix-map Hongxu Jia
2016-03-18 9:01 ` [PATCH 03/18] kernel.bbclass: fix buildpath QA issue Hongxu Jia
2016-03-18 9:01 ` [PATCH 04/18] valgrind: " Hongxu Jia
2016-03-18 9:01 ` [PATCH 05/18] dtc.inc: fix buildpaths " Hongxu Jia
2016-03-18 12:01 ` Jussi Kukkonen
2016-03-18 13:04 ` Hongxu Jia
2016-03-18 9:01 ` [PATCH 06/18] fix_buildpaths.bbclass: add bbclass to fix build path Hongxu Jia
2016-03-18 9:01 ` [PATCH 07/18] icu: fix buildpaths QA issue Hongxu Jia
2016-03-18 9:01 ` [PATCH 08/18] tcl: fix buildpath " Hongxu Jia
2016-03-18 9:01 ` [PATCH 09/18] python2/3: " Hongxu Jia
2016-03-18 9:01 ` [PATCH 10/18] bbclass distutils/distutils3: fix .pyc/.pyo buildpath Hongxu Jia
2016-03-18 9:01 ` [PATCH 11/18] bbclass distutils/distutils3/setuptools/setuptools3: clean up DISTUTILS_INSTALL_ARGS Hongxu Jia
2016-03-18 9:01 ` [PATCH 12/18] python-setuptools/python3-setuptools: use old-style install Hongxu Jia
2016-03-18 9:01 ` [PATCH 13/18] python3-pip: " Hongxu Jia
2016-03-18 9:01 ` [PATCH 14/18] waf.bbclass: support do patch on extracted files Hongxu Jia
2016-03-18 9:01 ` [PATCH 15/18] python-pycairo: fix buildpath QA issue Hongxu Jia
2016-03-18 9:01 ` [PATCH 16/18] openssl: " Hongxu Jia
2016-03-18 9:01 ` [PATCH 17/18] gconf: fix buildpaths " Hongxu Jia
2016-03-18 16:28 ` Burton, Ross
2016-03-19 9:09 ` Hongxu Jia
2016-03-18 9:02 ` [PATCH 18/18] epiphany: " Hongxu Jia
2016-03-19 14:56 ` [PATCH V4 00/18] " Hongxu Jia
2016-03-19 14:56 ` [PATCH 06/18] fix_buildpaths.bbclass: add bbclass to fix build path Hongxu Jia
2016-03-19 14:56 ` [PATCH 07/18] icu: fix buildpaths QA issue Hongxu Jia
2016-03-19 14:56 ` [PATCH 09/18] python2/3: fix buildpath " Hongxu Jia
2016-03-19 14:56 ` [PATCH 16/18] openssl: " Hongxu Jia
2016-03-19 14:56 ` [PATCH 18/18] gconf: fix buildpaths " Hongxu Jia
2016-03-21 14:47 ` Burton, Ross
2016-03-22 1:16 ` Hongxu Jia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F09CD9.7020802@windriver.com \
--to=hongxu.jia@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox