From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mail.openembedded.org (Postfix) with ESMTP id 892EA6AC00 for ; Tue, 22 Mar 2016 18:20:15 +0000 (UTC) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 22 Mar 2016 11:20:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,378,1455004800"; d="asc'?scan'208,217";a="929588750" Received: from afshjern.zpn.intel.com (HELO [10.219.16.250]) ([10.219.16.250]) by fmsmga001.fm.intel.com with ESMTP; 22 Mar 2016 11:20:15 -0700 To: "Burton, Ross" References: <1458664665-20517-1-git-send-email-alejandro.franco@linux.intel.com> <56F17581.70809@linux.intel.com> From: Alex Franco Message-ID: <56F18D31.8020402@linux.intel.com> Date: Tue, 22 Mar 2016 12:21:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Cc: Joshua G Lock , Benjamin Esquivel , Andreas Schultz , OE-core Subject: Re: [PATCH] nativesdk-buildtools-perl-dummy.bb: disable ICECC X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 18:20:17 -0000 X-Groupsio-MsgNum: 79971 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="o2Hv24hx4MusSCIONvLjc2gfnNrvEEAs6" --o2Hv24hx4MusSCIONvLjc2gfnNrvEEAs6 Content-Type: multipart/mixed; boundary="W8TqF3Vx4cBO4OMafs2JEWSACW8BH33TO" From: Alex Franco To: "Burton, Ross" Cc: OE-core , Joshua G Lock , Benjamin Esquivel , Andreas Schultz Message-ID: <56F18D31.8020402@linux.intel.com> Subject: Re: [OE-core] [PATCH] nativesdk-buildtools-perl-dummy.bb: disable ICECC References: <1458664665-20517-1-git-send-email-alejandro.franco@linux.intel.com> <56F17581.70809@linux.intel.com> In-Reply-To: --W8TqF3Vx4cBO4OMafs2JEWSACW8BH33TO Content-Type: multipart/alternative; boundary="------------050501020902070707030304" --------------050501020902070707030304 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ross, I suppose you mean " icc_is_allarch()" ? Ok , so this recipe does inherit allarch but it is sort of nativesdk, and when the test icc_is_allarch() checks for the value of 'PACKAGE_ARCH', it gets "buildtools-dummy-${SDKPKGSUFFIX}" (which should expand to 'buildtools-dummy-nativesdk', but doesn't) instead of the expected "all". I am now modifying this test to check for an inherit of allarch, and playing a bit with this. I'll keep you posted. Other stuff to consider: - Expand the value of PACKAGE_ARCH if necessary? I am doing it now as part of my tests but not sure I will be committing this: package_arch =3D d.getVar("PACKAGE_ARCH", False) if '${' in package_arch: package_arch =3D d.expand(package_arch) ... - All of these functions in the icecc.bbclass that incude "icc" in their names, should probably be modified to say "icecc" instead. As it stands now, it can cause confusion as some people might think we're talking about the intel c compiler rather than the icecream compiler - I wonder if there's a bug for this already Alex Franco On 03/22/2016 10:45 AM, Burton, Ross wrote: > > On 22 March 2016 at 16:41, Burton, Ross > wrote: > > Do we understand why this recipe breaks the icecc class? > > > So I'm guessing it's because the architecture of the recipe is > "special" - it's sort-of allarch and sort of nativesdk. > > I wonder if changing the icecc_is_allarch() test to check for inherit > of allarch would fix this without working around the problem. > > Ross=20 > --------------050501020902070707030304 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ross, I suppose you mean " icc_is_allarch()" ?

Ok , so this recipe does inherit allarch but it is sort of nativesdk, and when the test icc_is_allarch() checks for the value of 'PACKAGE_ARCH', it gets "buildtools-dummy-${SDKPKGSUFFIX}" (which should expand to 'buildtools-dummy-nativesdk', but doesn't) instead of the expected "all".

I am now modifying this test to check for an inherit of allarch, and playing a bit with this. I'll keep you posted.

Other stuff to consider:

- Expand the value of PACKAGE_ARCH if necessary? I am doing it now as part of my tests but not sure I will be committing this:

=C2=A0=C2=A0=C2=A0=C2=A0 package_arch =3D d.getVar("PACKAGE_ARCH", Fa= lse)
=C2=A0=C2=A0=C2=A0=C2=A0 if '${' in package_arch:
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 package_arch =3D d.e= xpand(package_arch)
=C2=A0=C2=A0=C2=A0 ...

- All of these functions in the icecc.bbclass that incude "icc" in their names, should probably be modified to say "icecc" instead. As it stands now, it can cause confusion as some people might think we're talking about the intel c compiler rather than the icecream compiler - I wonder if there's a bug for this already

Alex Franco

On 03/22/2016 10:45 AM, Burton, Ross wrote:

On 22 March 2016 at 16:41, Burton, Ross <r= oss.burton@intel.com> wrote:
Do we understand why this recipe= breaks the icecc class?

So I'm guessing it's because the architecture of the recipe is "special" - it's sort-of allarch and sort of nativesdk.

I wonder if changing the icecc_is_allarch() test to check for inherit of allarch would fix this without working around the problem.

Ross=C2=A0


--------------050501020902070707030304-- --W8TqF3Vx4cBO4OMafs2JEWSACW8BH33TO-- --o2Hv24hx4MusSCIONvLjc2gfnNrvEEAs6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJW8Y0xAAoJEPR9uwMY2lTLOTAH/1ZPWNrNePlS87tfPy2xTHAj OKPPKpLyyHj8aRhLG6GnWi3l9thhBueCZiqhs6I7gsKN55iOfatYCJI6RBViNL4H zk/jpYxhwPCVAI62btTOjGAVMPCBIDt/qH0RvcDYu0gwG1tp+9veNO/Pg37XcP9v iYd5ScjAjaCAU2ZBWnRaTiaMHi2v2enlijhmHlVrfnn5vUrBv9KuZ5PIZisoErS+ JObygt3FKlj+Flri06R3QpCUfFXf3E3x4dGD88i8tJNo5da59NphUulQmi9CK2GN 7KvyinkIFRuRTNv6Lm9Em28YE7H66Nx/MrZPbkfS+HvrPCgkOB89qL/3M2xF01s= =YmgY -----END PGP SIGNATURE----- --o2Hv24hx4MusSCIONvLjc2gfnNrvEEAs6--