Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mariano Lopez <mariano.lopez@linux.intel.com>
To: Christopher Larson <clarson@kergoth.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] archiver.bbclass: Just archive gcc-source for all gcc recipes
Date: Mon, 28 Mar 2016 12:09:08 -0600	[thread overview]
Message-ID: <56F97344.9040204@linux.intel.com> (raw)
In-Reply-To: <CABcZANkt+zzsRKL7ao2aP81Cu7Easc5rmmGHQzBdy0jwRNTDQg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]



On 03/24/2016 12:04 PM, Christopher Larson wrote:
>
>
> On Thu, Mar 24, 2016 at 8:26 AM <mariano.lopez@linux.intel.com 
> <mailto:mariano.lopez@linux.intel.com>> wrote:
>
>     From: Mariano Lopez <mariano.lopez@linux.intel.com
>     <mailto:mariano.lopez@linux.intel.com>>
>     +    # We just archive gcc-source for all the gcc related recipes
>     +    if d.getVar('BPN', True) in ['gcc', 'libgcc'] \
>     +            and not pn.startswith('gcc-source'):
>     +        bb.debug(1, 'archiver: %s is excluded, covered by
>     gcc-source' % pn)
>     +        return
>
>
> Hmm, I wonder if it'd be possible to make this more generic, check for 
> work-shared or something.

I was thinking the same when writing the patch, but it seems gcc is more 
of a corner case. The only two recipes that use work-shared are gcc and 
the kernel, the kernel case it's already covered checking for the class 
"kernel-yocto". In case of gcc we can't check for a class, we would need 
for work-shared and gcc, and that would be the almost the same 
comparison as is in the patch.

Mariano

[-- Attachment #2: Type: text/html, Size: 2278 bytes --]

  reply	other threads:[~2016-03-28 18:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1458803813.git.mariano.lopez@linux.intel.com>
2016-03-24  7:20 ` [PATCH 1/1] archiver.bbclass: Just archive gcc-source for all gcc recipes mariano.lopez
2016-03-24 18:04   ` Christopher Larson
2016-03-28 18:09     ` Mariano Lopez [this message]
2016-03-28 18:43       ` Christopher Larson
2016-03-28 22:18         ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56F97344.9040204@linux.intel.com \
    --to=mariano.lopez@linux.intel.com \
    --cc=clarson@kergoth.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox