From: Robert Yang <liezhi.yang@windriver.com>
To: Dan McGregor <danismostlikely@gmail.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] fs-perms.txt: fix ROOT_HOME's permission
Date: Fri, 8 Apr 2016 08:47:07 +0800 [thread overview]
Message-ID: <5706FF8B.1060706@windriver.com> (raw)
In-Reply-To: <CACS+7ZSOJg9gpWGKAKM2dA6Y6Se4wcj+DWFpjOdKS014fqZWYQ@mail.gmail.com>
On 04/07/2016 11:55 PM, Dan McGregor wrote:
> On 7 April 2016 at 07:46, Robert Yang <liezhi.yang@windriver.com> wrote:
>>
>>
>> On 04/07/2016 09:30 PM, Dan McGregor wrote:
>>>
>>> On 7 April 2016 at 01:50, Robert Yang <liezhi.yang@windriver.com> wrote:
>>>>
>>>> It should be 0700 rather than 0755.
>>>>
>>>> Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>>>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>>> ---
>>>> meta/files/fs-perms.txt | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
>>>> index 109cbe5..1d74da7 100644
>>>> --- a/meta/files/fs-perms.txt
>>>> +++ b/meta/files/fs-perms.txt
>>>> @@ -51,6 +51,7 @@ ${localstatedir}/lock link /run/lock
>>>> ${localstatedir}/tmp link volatile/tmp
>>>>
>>>> /home 0755 root root false - - -
>>>> +${ROOT_HOME} 0700 root root false - - -
>>>
>>>
>>> I'd like to see this in the section labelled "Special permissions from
>>> base-files" around line 58. I think that makes it more clear that this
>>> is a special permission setting.
>>
>>
>> Thanks, updated in the repo:
>>
>> git://git.openembedded.org/openembedded-core-contrib rbt/home
>>
>> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
>>
>>
>> commit ccc59f44f5fc6c6ccef6b0fed58b0d582c9ee32b
>> Author: Robert Yang <liezhi.yang@windriver.com>
>> Date: Tue Apr 5 22:34:25 2016 -0700
>>
>> fs-perms.txt: fix ROOT_HOME's permission
>>
>> It should be 0700 rather than 0755.
>>
>> Reported-by: Charles Chan <charles.wh.chan@gmail.com>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>>
>> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
>> index 109cbe5..6c1083c 100644
>> --- a/meta/files/fs-perms.txt
>> +++ b/meta/files/fs-perms.txt
>> @@ -59,6 +59,7 @@ ${localstatedir}/local 0755 root root
>> false - - -
>> # Set 1777
>> /tmp 01777 root root false - - -
>> ${localstatedir}/volatile/tmp 01777 root root false - - -
>> +${ROOT_HOME} 0700 root root false - - -
>>
>
> Thanks, this is the right track, but this implies that ${ROOT_HOME}
> should be mode 1777, how about:
>
> +
> +# Set 700
> +${ROOT_HOME} 0700 root root false - - -
Thanks, updated in the repo:
git://git.openembedded.org/openembedded-core-contrib rbt/home
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/home
commit 5d0c64fd55edc957d8fb6340c9842bf8498a485d
Author: Robert Yang <liezhi.yang@windriver.com>
Date: Tue Apr 5 22:34:25 2016 -0700
fs-perms.txt: fix ROOT_HOME's permission
It should be 0700 rather than 0755.
Reported-by: Charles Chan <charles.wh.chan@gmail.com>
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
index 109cbe5..3d00e86 100644
--- a/meta/files/fs-perms.txt
+++ b/meta/files/fs-perms.txt
@@ -60,6 +60,9 @@ ${localstatedir}/local 0755 root root
false - - -
/tmp 01777 root root false - - -
${localstatedir}/volatile/tmp 01777 root root false - - -
+# Set 0700
+${ROOT_HOME} 0700 root root false - - -
+
# Set 755-lsb
/srv 0755 root root false - - -
// Robert
>
>> # Set 755-lsb
>> /srv 0755 root root false - - -
>>
>>
>> // Robert
>>
>>
>>>
>>>
>>>> /srv 0755 root root false - - -
>>>> ${prefix}/src 0755 root root false - - -
>>>> ${localstatedir}/local 0755 root root false - - -
>>>> --
>>>> 2.8.0
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>>
>>
>
next prev parent reply other threads:[~2016-04-08 0:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 7:50 [PATCH 0/1] fs-perms.txt: fix ROOT_HOME's permission Robert Yang
2016-04-07 7:50 ` [PATCH 1/1] " Robert Yang
2016-04-07 13:30 ` Dan McGregor
2016-04-07 13:46 ` Robert Yang
2016-04-07 15:55 ` Dan McGregor
2016-04-08 0:47 ` Robert Yang [this message]
2016-04-08 3:49 ` Dan McGregor
2016-04-14 16:23 ` Dan McGregor
2016-04-14 16:33 ` Burton, Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5706FF8B.1060706@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=danismostlikely@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox