From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.dream-property.net (mail.dream-property.net [82.149.226.172]) by mail.openembedded.org (Postfix) with ESMTP id 71A2D6AC3C for ; Fri, 8 Apr 2016 01:25:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.dream-property.net (Postfix) with ESMTP id D893A3141D3B; Fri, 8 Apr 2016 03:25:18 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.dream-property.net Received: from mail.dream-property.net ([127.0.0.1]) by localhost (mail.dream-property.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id gvcAVXCDUods; Fri, 8 Apr 2016 03:25:16 +0200 (CEST) Received: from [172.22.22.61] (55d40344.access.ecotel.net [85.212.3.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.dream-property.net (Postfix) with ESMTPSA id 3D5873141D3A; Fri, 8 Apr 2016 03:25:16 +0200 (CEST) To: Khem Raj References: <1460012563-18898-1-git-send-email-raj.khem@gmail.com> <57069A2A.4040901@opendreambox.org> <5706F15A.3080205@opendreambox.org> From: Andreas Oberritter Message-ID: <5707087B.8040905@opendreambox.org> Date: Fri, 8 Apr 2016 03:25:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH] busybox/mdev: Ensure /sys is mounted before using it X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2016 01:25:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 08.04.2016 03:10, Khem Raj wrote: > > On Apr 7, 2016 4:46 PM, "Andreas Oberritter" > wrote: >> >> On 07.04.2016 21:01, Khem Raj wrote: >> > >> >> On Apr 7, 2016, at 10:34 AM, Andreas Oberritter > > wrote: >> >> >> >> Hi Khem, >> >> >> >> On 07.04.2016 09:02, Khem Raj wrote: >> >>> echo would fail if /sys is not mounted and boot would abort >> >> >> >> are you sure about the dependency between echo and sysfs? It seems > quite >> >> unlikely to me. I'd guess the real problem is mdev failing to start >> >> without syses. >> > >> > real problem was missing mounting sysfs on /sys, but I wanted to > keep the other >> > way of setting it instead of echo >> >> Note that I was referring to your commit message. >> >> After a second look I see that you also mount /proc in your patch, and I >> guess that's what you meant to describe. Please update the commit >> message (and subject) to actually match your patch. > > Whata not clear in patch subject It doesn't mention /proc. >> >> Regards, >> Andreas >> >> >> > >> >> >> >> Regards, >> >> Andreas >> >> >> >> >> >>> >> >>> Signed-off-by: Khem Raj > >> >>> --- >> >>> meta/recipes-core/busybox/files/mdev | 4 +++- >> >>> 1 file changed, 3 insertions(+), 1 deletion(-) >> >>> >> >>> diff --git a/meta/recipes-core/busybox/files/mdev > b/meta/recipes-core/busybox/files/mdev >> >>> index 9625247..8c9c06e 100755 >> >>> --- a/meta/recipes-core/busybox/files/mdev >> >>> +++ b/meta/recipes-core/busybox/files/mdev >> >>> @@ -1,10 +1,12 @@ >> >>> #!/bin/sh >> >>> - >> >>> +mount -t proc proc /proc >> >>> +mount -t sysfs sysfs /sys >> >>> mount -t tmpfs tmpfs /dev -o size=64k,mode=0755 >> >>> mkdir /dev/pts /dev/shm >> >>> chmod 777 /dev/shm >> >>> mount -t devpts devpts /dev/pts >> >>> touch /dev/mdev.seq >> >>> +#sysctl -w kernel.hotplug=/sbin/mdev >> >>> echo "/sbin/mdev" > /proc/sys/kernel/hotplug >> >>> mdev -s >> >>> >> >>> >> >> >> >> -- >> >> _______________________________________________ >> >> Openembedded-core mailing list >> >> Openembedded-core@lists.openembedded.org > >> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> > >> >