Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: Khem Raj <raj.khem@gmail.com>,
	Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] Access c_ispeed and c_ospeed via APIs
Date: Tue, 12 Apr 2016 17:05:35 -0400	[thread overview]
Message-ID: <570D631F.5020503@windriver.com> (raw)
In-Reply-To: <CAMKF1sp7C3zCHQBiJ=i5YYsHcXfkBX74qYXgZxYX-tqcwqrD+A@mail.gmail.com>

On 2016-04-12 1:53 PM, Khem Raj wrote:
> FYI

Thanks. I can also confirm that when I dropped the patch, I'm
back up and running assertion free.

Bruce

>
> ---------- Forwarded message ----------
> From: Gerhard Rieger <gerhard@dest-unreach.org>
> Date: Wed, Mar 16, 2016 at 4:43 AM
> Subject: Re: [PATCH] Access c_ispeed and c_ospeed via APIs
> To: Khem Raj <raj.khem@gmail.com>
>
>
> Thank you, I will check this patch!
> - Gerhard
>
>
> Am 15.03.2016 um 22:39 schrieb Khem Raj:
>> Use cfsetispeed(), cfsetospeed(), cfgetispeed, and cfgetospeed()
>> instead of operating on c_ispeed and c_ospeed termios structure
>> members directly because they are not guaranteed to exist on all
>> libc implementations
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>   xioinitialize.c | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/xioinitialize.c b/xioinitialize.c
>> index 9f50155..632ca4c 100644
>> --- a/xioinitialize.c
>> +++ b/xioinitialize.c
>> @@ -65,10 +65,10 @@ int xioinitialize(void) {
>>   #if HAVE_TERMIOS_ISPEED && (ISPEED_OFFSET != -1) && (OSPEED_OFFSET != -1)
>>   #if defined(ISPEED_OFFSET) && (ISPEED_OFFSET != -1)
>>   #if defined(OSPEED_OFFSET) && (OSPEED_OFFSET != -1)
>> -      tdata.termarg.c_ispeed = 0x56789abc;
>> -      tdata.termarg.c_ospeed = 0x6789abcd;
>> -      assert(tdata.termarg.c_ispeed == tdata.speeds[ISPEED_OFFSET]);
>> -      assert(tdata.termarg.c_ospeed == tdata.speeds[OSPEED_OFFSET]);
>> +      cfsetispeed(&tdata.termarg, 0x56789abc);
>> +      cfsetospeed(&tdata.termarg, 0x6789abcd);
>> +      assert(cfgetispeed(&tdata.termarg) == tdata.speeds[ISPEED_OFFSET]);
>> +      assert(cfgetospeed(&tdata.termarg) == tdata.speeds[OSPEED_OFFSET]);
>>   #endif
>>   #endif
>>   #endif
>>



  reply	other threads:[~2016-04-12 21:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1458077979-23303-1-git-send-email-raj.khem@gmail.com>
     [not found] ` <56E91CC8.9060907@dest-unreach.org>
2016-04-12 17:53   ` [PATCH] Access c_ispeed and c_ospeed via APIs Khem Raj
2016-04-12 21:05     ` Bruce Ashfield [this message]
2016-04-12 22:20       ` Khem Raj
     [not found]         ` <CAMKF1srQ5ayOr3ha=YTTGBS-ovX8Ht41ODoNaSEHBGW9EfjFGA@mail.gmail.com>
     [not found]           ` <CAMKF1sqBwbkHWQBBzX8jbK0SoZtcMr6MO2ZSZ9dcMJJns6x+eQ@mail.gmail.com>
2016-04-12 22:33             ` Khem Raj
2016-04-13 15:57               ` Khem Raj
2016-04-13 15:59                 ` Bruce Ashfield
2016-04-13 17:15                 ` Bruce Ashfield
2016-04-13 17:17                   ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570D631F.5020503@windriver.com \
    --to=bruce.ashfield@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox