From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <marex@denx.de>
Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])
	by mail.openembedded.org (Postfix) with ESMTP id 4F3616072C
	for <openembedded-core@lists.openembedded.org>;
	Wed, 13 Apr 2016 22:39:32 +0000 (UTC)
Received: from mail.nefkom.net (unknown [192.168.8.184])
	by mail-out.m-online.net (Postfix) with ESMTP id 3qldyr3TGvz3hht5;
	Thu, 14 Apr 2016 00:39:32 +0200 (CEST)
X-Auth-Info: orIU/1RM65ws67xdIvFvavG5+5Qh9QQ3phAW2LVbnac=
Received: from [IPv6:::1] (unknown [195.140.253.167])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by smtp-auth.mnet-online.de (Postfix) with ESMTPSA id 3qldyq4lc6zvdWS; 
	Thu, 14 Apr 2016 00:39:31 +0200 (CEST)
Message-ID: <570EC087.5050805@denx.de>
Date: Wed, 13 Apr 2016 23:56:23 +0200
From: Marek Vasut <marex@denx.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:31.0) Gecko/20100101 Icedove/31.7.0
MIME-Version: 1.0
To: Ruslan Bilovol <rbilovol@cisco.com>, 
	openembedded-core@lists.openembedded.org
References: <1460571440-14500-1-git-send-email-rbilovol@cisco.com>
In-Reply-To: <1460571440-14500-1-git-send-email-rbilovol@cisco.com>
Cc: xe-linux-external@cisco.com
Subject: Re: [PATCH v2] kernel-uimage: change target image to vmlinux
X-BeenThere: openembedded-core@lists.openembedded.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Patches and discussions about the oe-core layer
	<openembedded-core.lists.openembedded.org>
List-Unsubscribe: <http://lists.openembedded.org/mailman/options/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=unsubscribe>
List-Archive: <http://lists.openembedded.org/pipermail/openembedded-core/>
List-Post: <mailto:openembedded-core@lists.openembedded.org>
List-Help: <mailto:openembedded-core-request@lists.openembedded.org?subject=help>
List-Subscribe: <http://lists.openembedded.org/mailman/listinfo/openembedded-core>,
	<mailto:openembedded-core-request@lists.openembedded.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Apr 2016 22:39:33 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 04/13/2016 08:17 PM, Ruslan Bilovol wrote:
> Commit e69525: "kernel: Build uImage only when really
> needed" hardcoded target kernel image to zImage for
> case if uImage is generated by OpenEmbedded buildsystem.
> 
> However not all kernel architectures support zImage
> target, for example AArch64 doesn't, so building of
> kernel is failing on this step.
> 
> So instead of building zImage target that may not
> exist for many architectures, build vmlinux target
> that exists for all architectures.
> 
> Since kernel-uboot.bbclass uses vmlinux anyway for
> creating image, there is no side effect on this change.
> 
> Signed-off-by: Ruslan Bilovol <rbilovol@cisco.com>

To me, this looks sensible:

Reviewed-by: Marek Vasut <marex@denx.de>

If someone depends on this uImage bbclass generating also zImage,
there will be a failure and that should be fixed therein.

> ---
>  meta/classes/kernel-uimage.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/kernel-uimage.bbclass b/meta/classes/kernel-uimage.bbclass
> index f73965b..de7ca38 100644
> --- a/meta/classes/kernel-uimage.bbclass
> +++ b/meta/classes/kernel-uimage.bbclass
> @@ -13,7 +13,7 @@ python __anonymous () {
>  	# KEEPUIMAGE == yes. Otherwise, we pack compressed vmlinux into
>  	# the uImage .
>  	if d.getVar("KEEPUIMAGE", True) != 'yes':
> -            d.setVar("KERNEL_IMAGETYPE_FOR_MAKE", "zImage")
> +            d.setVar("KERNEL_IMAGETYPE_FOR_MAKE", "vmlinux")
>  }
>  
>  do_uboot_mkimage() {
> 


-- 
Best regards,
Marek Vasut