Openembedded Core Discussions
 help / color / mirror / Atom feed
From: akuster808 <akuster808@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: Armin Kuster <akuster@mvista.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib
Date: Mon, 16 May 2016 19:26:57 -0700	[thread overview]
Message-ID: <573A8171.50002@gmail.com> (raw)
In-Reply-To: <C6187355-EA77-4B31-8638-C5D64613DE0E@gmail.com>



On 05/16/2016 09:44 AM, Khem Raj wrote:
> 
>> On May 16, 2016, at 9:17 AM, Armin Kuster <akuster808@gmail.com> wrote:
>>
>> From: Armin Kuster <akuster@mvista.com>
>>
>> numpy/core/include/numpy/npy_common.h:149:10: error:
>> |          #error Unsupported size for type off_t
>>
>> Signed-off-by: Armin Kuster <akuster@mvista.com>
>> ---
>> meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>> index 191e5a1..109deb0 100644
>> --- a/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>> +++ b/meta/recipes-devtools/python/python-numpy/aarch64/_numpyconfig.h
>> @@ -11,6 +11,7 @@
>> #define NPY_SIZEOF_PY_INTPTR_T 8
>> #define NPY_SIZEOF_PY_LONG_LONG 8
>> #define NPY_SIZEOF_LONGLONG 8
>> +#define NPY_SIZEOF_OFF_T 8
> 
> Why does the test to select size of off_t fails ?
core/include/numpy/npy_common.h

  #if NPY_SIZEOF_OFF_T == NPY_SIZEOF_SHORT
        #define NPY_OFF_T_PYFMT "h"
    #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_INT
        #define NPY_OFF_T_PYFMT "i"
    #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONG
        #define NPY_OFF_T_PYFMT "l"
    #elif NPY_SIZEOF_OFF_T == NPY_SIZEOF_LONGLONG
        #define NPY_OFF_T_PYFMT "L"
    #else
        #error Unsupported size for type off_t
    #endif

its gotta match one of them. X86-64 has NPY_SIZEOF_OFF_T  value set.


> we might need similar fix for mips64 too.
yep, I just built mips64 and ppc64 and they both fail like aach64.

will send v2 to fix those as well.

-armin

> 
>> #define NPY_NO_SMP 0
>> #define NPY_HAVE_DECL_ISNAN
>> #define NPY_HAVE_DECL_ISINF
>> --
>> 2.3.5
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 


  reply	other threads:[~2016-05-17  2:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-16 16:17 [master][krogoth][PATCH] python-numpy: fix build failure with python-matplotlib Armin Kuster
2016-05-16 16:44 ` Khem Raj
2016-05-17  2:26   ` akuster808 [this message]
2016-05-17  3:09     ` Khem Raj
2016-05-17  3:16       ` akuster808
2016-05-17  3:34       ` akuster808
2016-05-17  3:35         ` Khem Raj
2016-05-17 13:19           ` akuster808
2016-05-17 14:22             ` Burton, Ross
2016-05-17 14:57               ` Khem Raj
2016-05-17 13:49         ` Burton, Ross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573A8171.50002@gmail.com \
    --to=akuster808@gmail.com \
    --cc=akuster@mvista.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox