From: Ming Liu <liu.ming50@gmail.com>
To: Christopher Larson <clarson@kergoth.com>
Cc: yue.tao@windriver.com,
Ming Liu <peter.x.liu@external.atlascopco.com>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] initscripts: hide the error in case swapoff does not exist
Date: Thu, 26 May 2016 22:25:23 +0200 [thread overview]
Message-ID: <57475BB3.1020401@gmail.com> (raw)
In-Reply-To: <CABcZANk9BJp_1wMrv7mR8-vLk3JfMkdxRqTMqcWm62nHkCrnBw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
On 05/26/2016 10:11 PM, Christopher Larson wrote:
>
>
> On Thu, May 26, 2016 at 12:44 PM, Ming Liu <liu.ming50@gmail.com
> <mailto:liu.ming50@gmail.com>> wrote:
>
> From: Ming Liu <peter.x.liu@external.atlascopco.com
> <mailto:peter.x.liu@external.atlascopco.com>>
>
> To avoid reporting errors when swapoff does not exist.
>
> Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com
> <mailto:peter.x.liu@external.atlascopco.com>>
>
>
> This will suppress *real* errors as well. Better to just check if
> swapoff exists and then run it if it does, if that's a concern.
Yes, checking if it exists makes more sense. And swapon is being used
with 2> /dev/null as well in some places, better to change them also. I
will send a V1 soon.
//Ming Liu
> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics
[-- Attachment #2: Type: text/html, Size: 2384 bytes --]
prev parent reply other threads:[~2016-05-26 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 19:44 [PATCH] initscripts: hide the error in case swapoff does not exist Ming Liu
2016-05-26 20:11 ` Christopher Larson
2016-05-26 20:25 ` Ming Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57475BB3.1020401@gmail.com \
--to=liu.ming50@gmail.com \
--cc=clarson@kergoth.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=peter.x.liu@external.atlascopco.com \
--cc=yue.tao@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox