Re: [PATCH] perl: reorder tar arguments in do_install_ptest()

["Aníbal Limón" <anibal.limon@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2706 bytes --]



On 05/30/2016 04:06 PM, Aníbal Limón wrote:
> 
> 
> On 05/30/2016 03:39 PM, Renato Caldas wrote:
>> Hi Aníbal,
>>
>> Sorry but I'm still a bit unfamiliar with the yocto workflow, should I
>> resubmit exact same patch with the [krogoth] prefix added, or should I
>> change the commit message in any way? It applies cleanly to both
>> master and krogoth.
> 
> You need to send two patches one with [krogoth] prefix and another
> without it for master.
> 
> Also is a good practice to cc the maintainer of the release [krogoth]
> release, since the 2.1 release was a little time ago i don't know who is
> the current maintainer sorry.

Reviewing this wiki [1] the maintainer for krogoth is Armin Kuster
<akuster@mvista.com>.

[1] https://wiki.yoctoproject.org/wiki/Releases

> 
> Cheers,
> 	alimon
> 
> 
>>
>> Cheers,
>>   Renato
>>
>> 2016-05-30 21:11 GMT+01:00 Aníbal Limón <anibal.limon@linux.intel.com>:
>>> Hi Renato,
>>>
>>> I tested the patch and works very well.
>>> Could you sent another patch with [krogoth] prefix to be backported?
>>>
>>> Thanks a lot,
>>>         alimon
>>>
>>>
>>> On 05/28/2016 06:53 AM, Renato Caldas wrote:
>>>> On some distributions tar requires the FILE argument to be the last, and
>>>> the existing order was causing the subsequent --exclude options to be dropped.
>>>>
>>>> Fixes [YOCTO #9673].
>>>>
>>>> Signed-off-by: Renato Caldas <rm.santos.caldas@gmail.com>
>>> Acked-by: Aníbal Limón <anibal.limon@linux.intel.com>
>>>> ---
>>>>  meta/recipes-devtools/perl/perl-ptest.inc | 4 ++--
>>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/meta/recipes-devtools/perl/perl-ptest.inc b/meta/recipes-devtools/perl/perl-ptest.inc
>>>> index 948ea7c..66c5355 100644
>>>> --- a/meta/recipes-devtools/perl/perl-ptest.inc
>>>> +++ b/meta/recipes-devtools/perl/perl-ptest.inc
>>>> @@ -7,8 +7,8 @@ do_install_ptest () {
>>>>       mkdir -p ${D}${PTEST_PATH}
>>>>       sed -e "s:\/opt:\/usr:" -i Porting/add-package.pl
>>>>       sed -e "s:\/local\/gnu\/:\/:" -i hints/cxux.sh
>>>> -     tar -cf - * --exclude \*.o --exclude libperl.so --exclude Makefile --exclude makefile --exclude hostperl \
>>>> -             --exclude miniperl --exclude generate_uudmap --exclude patches | ( cd ${D}${PTEST_PATH} && tar -xf - )
>>>> +     tar -cf - --exclude \*.o --exclude libperl.so --exclude Makefile --exclude makefile --exclude hostperl \
>>>> +             --exclude miniperl --exclude generate_uudmap --exclude patches * | ( cd ${D}${PTEST_PATH} && tar -xf - )
>>>>
>>>>       sed -i -e "s,${D},,g" \
>>>>              -e "s,--sysroot=${STAGING_DIR_HOST},,g" \
>>>>
>>>
> 
> 
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]