From: "Aníbal Limón" <anibal.limon@linux.intel.com>
To: Renato Caldas <rm.santos.caldas@gmail.com>,
openembedded-core@lists.openembedded.org
Cc: Armin Kuster <akuster@mvista.com>
Subject: Re: [master][PATCH] perl: reorder tar arguments in do_install_ptest()
Date: Mon, 30 May 2016 16:49:14 -0500 [thread overview]
Message-ID: <574CB55A.4080405@linux.intel.com> (raw)
In-Reply-To: <20160530214549.3766-1-rm.santos.caldas@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1471 bytes --]
Thanks for sending the patch, only a little comment the [master] prefix
isn't required.
alimon
On 05/30/2016 04:45 PM, Renato Caldas wrote:
> On some distributions tar requires the FILE argument to be the last, and
> the existing order was causing the subsequent --exclude options to be dropped.
>
> Fixes [YOCTO #9673].
>
> Signed-off-by: Renato Caldas <rm.santos.caldas@gmail.com>
> ---
> meta/recipes-devtools/perl/perl-ptest.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/perl/perl-ptest.inc b/meta/recipes-devtools/perl/perl-ptest.inc
> index 948ea7c..66c5355 100644
> --- a/meta/recipes-devtools/perl/perl-ptest.inc
> +++ b/meta/recipes-devtools/perl/perl-ptest.inc
> @@ -7,8 +7,8 @@ do_install_ptest () {
> mkdir -p ${D}${PTEST_PATH}
> sed -e "s:\/opt:\/usr:" -i Porting/add-package.pl
> sed -e "s:\/local\/gnu\/:\/:" -i hints/cxux.sh
> - tar -cf - * --exclude \*.o --exclude libperl.so --exclude Makefile --exclude makefile --exclude hostperl \
> - --exclude miniperl --exclude generate_uudmap --exclude patches | ( cd ${D}${PTEST_PATH} && tar -xf - )
> + tar -cf - --exclude \*.o --exclude libperl.so --exclude Makefile --exclude makefile --exclude hostperl \
> + --exclude miniperl --exclude generate_uudmap --exclude patches * | ( cd ${D}${PTEST_PATH} && tar -xf - )
>
> sed -i -e "s,${D},,g" \
> -e "s,--sysroot=${STAGING_DIR_HOST},,g" \
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2016-05-30 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 21:45 [master][PATCH] perl: reorder tar arguments in do_install_ptest() Renato Caldas
2016-05-30 21:49 ` Aníbal Limón [this message]
2016-05-30 21:50 ` Renato Caldas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574CB55A.4080405@linux.intel.com \
--to=anibal.limon@linux.intel.com \
--cc=akuster@mvista.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=rm.santos.caldas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox