From: "Ahmad Fatoum" <a.fatoum@pengutronix.de>
To: Nathan Rossi <nathan@nathanrossi.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] vim: add nativesdk to BBCLASSEXTEND
Date: Wed, 4 Nov 2020 14:32:11 +0100 [thread overview]
Message-ID: <574f594f-cdbf-0465-dc5e-5ca1033df19a@pengutronix.de> (raw)
In-Reply-To: <20201104131745.397780-1-nathan@nathanrossi.com>
Hello Nathan,
On 11/4/20 2:17 PM, Nathan Rossi wrote:
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
> ---
> meta/recipes-support/vim/vim_8.2.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-support/vim/vim_8.2.bb b/meta/recipes-support/vim/vim_8.2.bb
> index 709b6ddb55..7e4654e472 100644
> --- a/meta/recipes-support/vim/vim_8.2.bb
> +++ b/meta/recipes-support/vim/vim_8.2.bb
> @@ -3,7 +3,7 @@ require vim.inc
> PROVIDES = "xxd"
>
> PACKAGECONFIG_class-native = ""
> -BBCLASSEXTEND = "native"
> +BBCLASSEXTEND = "native nativesdk"
Apologies if this is self-evident, but why should nativesdk be added here?
A commit message explaining the why would be quite helpful.
>
> ALTERNATIVE_${PN}_append = " xxd"
> ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
> ---
> 2.28.0
>
>
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2020-11-04 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 13:17 [PATCH] vim: add nativesdk to BBCLASSEXTEND Nathan Rossi
2020-11-04 13:32 ` Ahmad Fatoum [this message]
2020-11-05 1:30 ` [OE-core] " Nathan Rossi
2020-11-05 9:49 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574f594f-cdbf-0465-dc5e-5ca1033df19a@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=nathan@nathanrossi.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox