From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by mail.openembedded.org (Postfix) with ESMTP id 65E0662135 for ; Mon, 20 Jun 2016 06:26:04 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id u5K6Q462007584 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Sun, 19 Jun 2016 23:26:04 -0700 (PDT) Received: from [128.224.162.229] (128.224.162.229) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 19 Jun 2016 23:26:03 -0700 To: "Burton, Ross" References: <9cc3d71a9624333bd6c3c676ee2b855be1903568.1466134498.git.Qi.Chen@windriver.com> From: ChenQi Message-ID: <57678C80.2050503@windriver.com> Date: Mon, 20 Jun 2016 14:26:08 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [128.224.162.229] Cc: OE-core Subject: Re: [PATCH 3/4] systemd-bootchart: add recipe X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2016 06:26:05 -0000 Content-Type: multipart/alternative; boundary="------------000505080603060405010104" --------------000505080603060405010104 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit On 06/18/2016 02:36 AM, Burton, Ross wrote: > > On 17 June 2016 at 04:36, Chen Qi > wrote: > > +DEPENDS = "libxslt-native libxslt-native xmlto-native > docbook-xml-dtd4-native docbook-xsl-stylesheets-native intltool" > > > Can we not disable documentation? Hi Ross, There's not available option to disable it in its source codes. Do you think we should try to add one for it? Or we just leave things as it is? Best Regards, Chen Qi > +SYSTEMD_SERVICE_${PN} = "systemd-bootchart.service" > +SYSTEMD_AUTO_ENABLE_${PN} = "disable" > > > Enable by default, I'd suggest. > > +do_configure_prepend() { > + # intltool.m4 is a soft link to /usr/share/aclocal/m4, delete > it and use the one in our sysroot > + rm ${S}/m4/intltool.m4 > + cp ${STAGING_DIR_TARGET}${datadir}/aclocal/intltool.m4 > ${S}/m4/intltool.m4 > +} > > > IIRC just deleting the file should be sufficient, as we'll pull it in > from the sysroot automatically. > > Ross --------------000505080603060405010104 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
On 06/18/2016 02:36 AM, Burton, Ross wrote:

On 17 June 2016 at 04:36, Chen Qi <Qi.Chen@windriver.com> wrote:
+DEPENDS = "libxslt-native libxslt-native xmlto-native docbook-xml-dtd4-native docbook-xsl-stylesheets-native intltool"

Can we not disable documentation?

Hi Ross,

There's not available option to disable it in its source codes.
Do you think we should try to add one for it? Or we just leave things as it is?

Best Regards,
Chen Qi

 
+SYSTEMD_SERVICE_${PN} = "systemd-bootchart.service"
+SYSTEMD_AUTO_ENABLE_${PN} = "disable"

Enable by default, I'd suggest.
 
+do_configure_prepend() {
+    # intltool.m4 is a soft link to /usr/share/aclocal/m4, delete it and use the one in our sysroot
+    rm ${S}/m4/intltool.m4
+    cp ${STAGING_DIR_TARGET}${datadir}/aclocal/intltool.m4 ${S}/m4/intltool.m4
+}

IIRC just deleting the file should be sufficient, as we'll pull it in from the sysroot automatically.

Ross

--------------000505080603060405010104--