Openembedded Core Discussions
 help / color / mirror / Atom feed
From: alexander.kanavin@linux.intel.com
To: "Jonathan Liu" <net147@gmail.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] ffmpeg: fix build when DISTRO_FEATURES doesn't contain x11
Date: Fri, 26 Feb 2016 16:43:40 +0200 (EET)	[thread overview]
Message-ID: <57788.10.252.8.77.1456497820.squirrel@linux.intel.com> (raw)
In-Reply-To: <CANwerB2gBZKqfkXoaFH_dhkQAfDvN7TLeBceyOxsdVJzaxDgGQ@mail.gmail.com>

>> I'd call that a bug, and should be simple to resolve (pass expand=True
>> when
>> fetching getVarFlags in the PACKAGECONFIG handling code).
>>
>> Ross
>
> Feel free to submit a patch to handle the PACKAGECONFIG expansion and
> then I can update the fix.

I think you need to solve this in a different way altogether. Write a
patch for the upstream code that turns a floating, implicit xv dependency
into something that can be explicitly turned on and off, and then add a
PACKAGECONFIG option for it to the recipe.

Alex


  reply	other threads:[~2016-02-26 13:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 10:52 [PATCH] ffmpeg: fix build when DISTRO_FEATURES doesn't contain x11 Jonathan Liu
2016-02-26 11:04 ` Martin Jansa
2016-02-26 11:17   ` Jonathan Liu
2016-02-26 12:33     ` Burton, Ross
2016-02-26 13:29       ` Jonathan Liu
2016-02-26 14:43         ` alexander.kanavin [this message]
2016-02-26 14:05           ` Jonathan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57788.10.252.8.77.1456497820.squirrel@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=net147@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox