From: "Yu, Mingli" <mingli.yu@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>,
Catalin Enache <catalin.enache@windriver.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] grub-efi: run autogen.sh before configure
Date: Tue, 12 Jul 2016 11:27:15 +0800 [thread overview]
Message-ID: <57846393.1090200@windriver.com> (raw)
In-Reply-To: <CAJTo0La2hOxuxNsEdoEVE2tKDsL_3nRd6zonG-iLn7_=HRtqyQ@mail.gmail.com>
On 2016年07月11日 18:22, Burton, Ross wrote:
>
> On 6 May 2016 at 13:13, Catalin Enache <catalin.enache@windriver.com
> <mailto:catalin.enache@windriver.com>> wrote:
>
> DEPENDS_class-target = "grub-efi-native"
> RDEPENDS_${PN}_class-target = "diffutils freetype"
> +DEPENDS += "autogen-native"
>
>
> Because += happens after overrides this results in autogen-native only a
> dependency in native builds, so you can't be sure it will be present for
> target builds.
Thanks Ross! Will update the line as:
DEPENDS_append = " autogen-native"
>
> Should the configure_prepend and autogen-native be added to grub2.inc so
> that every recipe has that dependency?
Hi Catalin,
Could you help to confirm if the three recipes (grub-efi_2.00.bb,
grub_2.00.bb, grub_git.bb) all need configure_prepend and
autogen-native? if yes, I will resent the patch to add configure_prepend
and autogen-native to grub2.inc, if not, then we still let it stay in
grub-efi recipe.
Thanks,
Grace
>
> Ross
>
>
next prev parent reply other threads:[~2016-07-12 3:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 12:13 [PATCH] grub-efi: run autogen.sh before configure Catalin Enache
2016-07-06 9:22 ` Yu, Mingli
2016-07-11 10:22 ` Burton, Ross
2016-07-12 3:27 ` Yu, Mingli [this message]
2016-07-12 10:57 ` Ioan-Adrian Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57846393.1090200@windriver.com \
--to=mingli.yu@windriver.com \
--cc=catalin.enache@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox