From: Mariano Lopez <mariano.lopez@linux.intel.com>
To: benjamin.esquivel@intel.com, openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] selftest/seltest.py: Add test to check imports from other layers
Date: Wed, 13 Jul 2016 15:05:22 -0500 [thread overview]
Message-ID: <57869F02.6070105@linux.intel.com> (raw)
In-Reply-To: <008101d1dd10$397e5190$ac7af4b0$@linux.intel.com>
On 07/13/2016 09:09 AM, Benjamin Esquivel wrote:
> Comments below
>
> The test looks good.
>
>> --- /dev/null
>> +++ b/meta-selftest/lib/oeqa/selftest/imported.py
>> @@ -0,0 +1,14 @@
>> +from oeqa.selftest.base import oeSelfTest from oeqa.utils.decorators
>> +import testcase
>> +
>> +class ImportedTests(oeSelfTest):
>> +
>> + def test_import_dummy(self):
> There is a bug where I am proposing some changes to the naming of the tests.
> I'll take this test name as an example:
> imported.ImportedTests.test_import_dummy. With my proposal I'd name this
> test something more along these lines:
> external_layer.ImportedTests.test_inconditional_pass.
I'll send v2 with the revised name
Mariano Lopez
prev parent reply other threads:[~2016-07-13 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1468328858.git.mariano.lopez@linux.intel.com>
2016-07-12 13:09 ` [PATCH 1/1] selftest/seltest.py: Add test to check imports from other layers mariano.lopez
2016-07-13 14:09 ` Benjamin Esquivel
2016-07-13 20:05 ` Mariano Lopez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57869F02.6070105@linux.intel.com \
--to=mariano.lopez@linux.intel.com \
--cc=benjamin.esquivel@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox