Re: [krogoth][PATCH 1/8] pkgconfig: Fix build with gcc-6

[akuster808 <akuster808@gmail.com>]

So this is the host gcc not the one in OE?

- armin

On 07/14/2016 06:49 PM, Tim Orling wrote:
> Our patch in master was on top of 0.29.1 update.
> commit b83a808fcbd3e7aec3b0757c7180cf83dac44e92
> 
> Apply to krogoth stable 0.29 version instead.
> 
> [YOCTO #9897] (Fedora-24)
> 
> Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
> ---
>  ...te-suppress-string-format-literal-warning.patch | 34 ++++++++++++++++++++++
>  meta/recipes-devtools/pkgconfig/pkgconfig_git.bb   |  1 +
>  2 files changed, 35 insertions(+)
>  create mode 100644 meta/recipes-devtools/pkgconfig/pkgconfig/0001-gdate-suppress-string-format-literal-warning.patch
> 
> diff --git a/meta/recipes-devtools/pkgconfig/pkgconfig/0001-gdate-suppress-string-format-literal-warning.patch b/meta/recipes-devtools/pkgconfig/pkgconfig/0001-gdate-suppress-string-format-literal-warning.patch
> new file mode 100644
> index 0000000..830d3d2
> --- /dev/null
> +++ b/meta/recipes-devtools/pkgconfig/pkgconfig/0001-gdate-suppress-string-format-literal-warning.patch
> @@ -0,0 +1,34 @@
> +The upstream patch would not apply cleanly, so perform the same changes.
> +
> +Original patch header:
> +From 00148329967adb196138372771052a3f606a6ea3 Mon Sep 17 00:00:00 2001
> +From: coypu <coypu@sdf.org>
> +Date: Wed, 2 Mar 2016 19:43:10 +0200
> +Subject: [PATCH 2/2] gdate: Suppress string format literal warning
> +
> +Newer versions of GCC emit an error here, but we know it's safe.
> +https://bugzilla.gnome.org/761550
> +
> +Upstream-Status: Backport
> +
> +Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com>
> +
> +Index: git/glib/glib/gdate.c
> +===================================================================
> +--- git.orig/glib/glib/gdate.c
> ++++ git/glib/glib/gdate.c
> +@@ -2439,6 +2439,8 @@ win32_strftime_helper (const GDate     *
> +  *
> +  * Returns: number of characters written to the buffer, or 0 the buffer was too small
> +  */
> ++#pragma GCC diagnostic push
> ++#pragma GCC diagnostic ignored "-Wformat-nonliteral"
> + gsize     
> + g_date_strftime (gchar       *s, 
> +                  gsize        slen, 
> +@@ -2549,3 +2551,5 @@ g_date_strftime (gchar       *s,
> +   return retval;
> + #endif
> + }
> ++
> ++#pragma GCC diagnostic pop
> diff --git a/meta/recipes-devtools/pkgconfig/pkgconfig_git.bb b/meta/recipes-devtools/pkgconfig/pkgconfig_git.bb
> index d34f608..cd4dc8e 100644
> --- a/meta/recipes-devtools/pkgconfig/pkgconfig_git.bb
> +++ b/meta/recipes-devtools/pkgconfig/pkgconfig_git.bb
> @@ -18,6 +18,7 @@ PV = "0.29+git${SRCPV}"
>  SRC_URI = "git://anongit.freedesktop.org/pkg-config \
>             file://pkg-config-native.in \
>             file://fix-glib-configure-libtool-usage.patch \
> +	   file://0001-gdate-suppress-string-format-literal-warning.patch \
>             "
>  
>  S = "${WORKDIR}/git"
>