From: Robert Yang <liezhi.yang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] btrfs-tools: fix installed-vs-shipped
Date: Thu, 21 Jul 2016 14:54:49 +0800 [thread overview]
Message-ID: <579071B9.1010705@windriver.com> (raw)
In-Reply-To: <579029B1.8030102@windriver.com>
On 07/21/2016 09:47 AM, Robert Yang wrote:
>
>
> On 07/20/2016 07:59 PM, Burton, Ross wrote:
>>
>> On 20 July 2016 at 06:54, Robert Yang <liezhi.yang@windriver.com
>> <mailto:liezhi.yang@windriver.com>> wrote:
>>
>> /lib64/udev/rules.d/64-btrfs-dm.rules
>>
>>
>> This says that the btrfstools recipe is broken, not the packaging. udev looks
>> in /lib no matter what $libdir is.
>>
>> udev reads UDEVLIBEXECDIR/rules.d, where udevlibexecdir=$(rootprefix)/lib/udev
>> and we pass rootprefix=$baseprefix (which defaults to /).
>
> Thanks, I was misleaded by eudev, whose udevlibexecdir is ${rootlibexecdir}
> which is ${libdir}/udev, so it is /lib64/udev. It supports /lib/udev and
> /lib64/udev as the code in eudev-3.2/src/udev/udev-rules.c shows:
>
> static const char* const rules_dirs[] = {
> UDEV_CONF_DIR "/rules.d",
> UDEV_RULES_DIR,
> UDEV_ROOT_RUN "/udev/rules.d",
> UDEV_LIBEXEC_DIR "/rules.d",
> #ifdef HAVE_SPLIT_USR
> "/lib/udev/rules.d",
> "/usr/lib/udev/rules.d",
> #endif
> NULL};
>
>
> But for systemd, it hardcoded to $(rootprefix)/lib/udev.
>
> I looked into tmp/deploy/rpms, the following packages doesn't install
> to /lib/udev, but /lib64/udev or /usr/lib64/udev:
>
> tmp/deploy/rpm/core2_64/pcmciautils-018-r1.0.core2_64.rpm
> tmp/deploy/rpm/core2_64/pulseaudio-server-8.0-r0.0.core2_64.rpm
> tmp/deploy/rpm/core2_64/alsa-utils-alsactl-1.1.1-r0.0.core2_64.rpm
> tmp/deploy/rpm/core2_64/mdadm-3.4-r0.0.core2_64.rpm
> tmp/deploy/rpm/core2_64/libinput-1.3.0-r0.0.core2_64.rpm
> tmp/deploy/rpm/core2_64/bluez5-5.40-r0.0.core2_64.rpm
Hi Ross,
I just found that when build with eudev, the files will be installed
to /lib64/udev, and when build with systemd, they will be inistalled
to /lib/udev, so I think that they are OK. They use
"pkg-config --variable=udevdir udev" to find udev dir, while systemd
is /lib/udev and eudev is /lib64/eudev.
The one which has problem is libinput which installs /usr/lib/udev or
/usr/lib64/udev, this in incorrect. Another problem is that systemd
doesn't install udev.pc.
I think that the fix for btrfs-tools is correct. I will send a V2 with
another 2 fixes.
// Robert
>
> I will fix all of them.
>
> // Robert
>
>>
>> Ross
next prev parent reply other threads:[~2016-07-21 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 5:54 [PATCH 0/1] btrfs-tools: fix installed-vs-shipped Robert Yang
2016-07-20 5:54 ` [PATCH 1/1] " Robert Yang
2016-07-20 11:59 ` Burton, Ross
2016-07-21 1:47 ` Robert Yang
2016-07-21 6:54 ` Robert Yang [this message]
2016-07-21 8:46 ` Burton, Ross
2016-07-21 9:02 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579071B9.1010705@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox