Re: [PATCH 1/8] e2fsprogs: 1.43 -> 1.43.1

Robert Yang
2016-07-25T02:53:15Z

On 07/23/2016 04:44 AM, Khem Raj wrote:
> On Jul 22, 2016 12:52 PM, "Burton, Ross" <ross.burton@intel.com
> <mailto:ross.burton@intel.com>> wrote:
> >
> >
> > On 22 July 2016 at 09:47, Robert Yang <liezhi.yang@windriver.com
> <mailto:liezhi.yang@windriver.com>> wrote:
> >>
> >> Sorry, updated in the repo:
> >>
> >> git://git.openembedded.org/openembedded-core-contrib
> <http://git.openembedded.org/openembedded-core-contrib> rbt/pu
> >
> >
> > And now I notice that its failing on musl:
> >
> > | (cd elfshared; i586-poky-linux-musl-gcc -m32 -march=i586
> --sysroot=/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-musl/build/build/tmp/sysroots/qemux86
> -o libcom_err.so.2.1 \
> > | -L../../../lib -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed -Wl,-z,relro
> -Wl,-z,now -fPIC -shared \
> > | -Wl,-soname,libcom_err.so.2 error_message.o et_name.o init_et.o com_err.o
> com_right.o )
> > | i586-poky-linux-musl-ar rc libcom_err.a error_message.o et_name.o init_et.o
> com_err.o com_right.o
> > | error_message.o: In function `init_debug':
> > | /usr/src/debug/e2fsprogs/1.43.1-r0/git/lib/et/error_message.c:260:
> undefined reference to `__stack_chk_fail_local'
> > | com_err.o: In function `default_com_err_proc':
> > | /usr/src/debug/e2fsprogs/1.43.1-r0/git/lib/et/com_err.c:63: undefined
> reference to `__stack_chk_fail_local'
> > | collect2: error: ld returned 1 exit status
> >
> > I guess the hardening needs to be glibc specific? (CC'ing Khem for an opinion).
>
> Musl work that have been done has been using hardening from day 1. So this
> should be fixed. Musl images work fine with pie

Hi Khem,

This happens on i586 (MACHINE=qemux86), the core2_64(MACHINE=qemux86-64) works
well. The failed option is -fstack-protector-strong, maybe something is wrong
with i586-musl-toolchain ?

// Robert

> >
> > Ross
>