On 07/25/2016 05:38 PM, Burton, Ross wrote:
>
> On 13 June 2016 at 14:32, <mariano.lopez@linux.intel.com 
> <mailto:mariano.lopez@linux.intel.com>> wrote:
>
>     +   features = 'INHERIT += "testexport"\n'
>
>
> You mean testimage here as that class isn't inherited by default.
>
>     +        features = 'TEST_SUITES = "ping ssh selftest"\n'
>
>
> This overwrites the first assignment to features, and neither is 
> actually written using self.write_config().
>
>     +   # Build core-image-sato and testimage
>     +        bitbake('core-image-sato socat')
>     +        bitbake('-c testimage core-image-sato')
>
>
> I personally believe that core-image-sato is massive overkill for 
> selftest and core-image-full-cmdline is just as comprehensive (has 
> ssh, for example) without building all of Sato.

I don't know what happened when I made this commit and submitted the 
patch, this patch is just wrong. I swear I tested it locally, perhaps I 
messed up the branches or something like that. I'll work on a v2 of this.

Mariano