From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by mail.openembedded.org (Postfix) with ESMTP id 3578A77146 for ; Thu, 8 Sep 2016 06:33:31 +0000 (UTC) Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id u886XVPr024141 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 7 Sep 2016 23:33:31 -0700 (PDT) Received: from [128.224.162.229] (128.224.162.229) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Sep 2016 23:33:30 -0700 To: Pau Espin Pedrol References: <72f9c03cf7bb25482acc9c40b775a4f294e772b6.1473240119.git.Qi.Chen@windriver.com> From: ChenQi Message-ID: <57D10664.3050007@windriver.com> Date: Thu, 8 Sep 2016 14:34:12 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [128.224.162.229] Cc: OE-core Subject: Re: [PATCH 3/3] pulseaudio: fix to manage user services corretly X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Sep 2016 06:33:32 -0000 Content-Type: multipart/alternative; boundary="------------050606000108010605060503" --------------050606000108010605060503 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit On 09/07/2016 06:29 PM, Pau Espin Pedrol wrote: > > > Pau Espin Pedrol > > 2016-09-07 11:22 GMT+02:00 Chen Qi >: > > Make use of the new SYSTEMD_USER_SERVICE variable added in > systemd.bbclass > to manage user services in pulseaudio-server package. > > Signed-off-by: Chen Qi > > --- > meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc > b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc > index 6ed79ef..f3754d7 100644 > --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc > +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc > @@ -124,8 +124,8 @@ FILES_${PN}-conf = "${sysconfdir}" > FILES_${PN}-bin += > "${sysconfdir}/default/volatiles/volatiles.04_pulse" > FILES_${PN}-server = "${bindir}/pulseaudio ${bindir}/start-* > ${sysconfdir} ${bindir}/pactl */udev/rules.d/*.rules > */*/udev/rules.d/*.rules ${systemd_user_unitdir}/*" > > -#SYSTEMD_PACKAGES = "${PN}-server" > -SYSTEMD_SERVICE_${PN}-server = "pulseaudio.service" > +SYSTEMD_PACKAGES = "${PN}-server" > +SYSTEMD_USER_SERVICE_${PN}-server = "pulseaudio.service > pulseaudio.socket" > > I think specifying "pulseaudio.socket" for > SYSTEMD_USER_SERVICE_${PN}-server should be enough, systemd.bbclass is > going to add the .service file afair. Add both: chenqi@pek-hostel-deb01:~/poky/build-systemd [1] $ ls tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/rootfs/etc/systemd/user default.target.wants sockets.target.wants Add pulseaudio.socket: chenqi@pek-hostel-deb01:~/poky/build-systemd [1] $ ls tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/rootfs/etc/systemd/user sockets.target.wants They have different results. I don't know a lot about pulseaudio. Can you confirm that pulseaudio.socket is enough? Regards, Chen Qi > FILES_${PN}-misc = "${bindir}/* ${libdir}/pulseaudio/libpulsedsp.so" > > -- > 1.9.1 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > > http://lists.openembedded.org/mailman/listinfo/openembedded-core > > > --------------050606000108010605060503 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
On 09/07/2016 06:29 PM, Pau Espin Pedrol wrote:


Pau Espin Pedrol

2016-09-07 11:22 GMT+02:00 Chen Qi <Qi.Chen@windriver.com>:
Make use of the new SYSTEMD_USER_SERVICE variable added in systemd.bbclass
to manage user services in pulseaudio-server package.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 6ed79ef..f3754d7 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -124,8 +124,8 @@ FILES_${PN}-conf = "${sysconfdir}"
 FILES_${PN}-bin += "${sysconfdir}/default/volatiles/volatiles.04_pulse"
 FILES_${PN}-server = "${bindir}/pulseaudio ${bindir}/start-* ${sysconfdir} ${bindir}/pactl */udev/rules.d/*.rules */*/udev/rules.d/*.rules ${systemd_user_unitdir}/*"

-#SYSTEMD_PACKAGES = "${PN}-server"
-SYSTEMD_SERVICE_${PN}-server = "pulseaudio.service"
+SYSTEMD_PACKAGES = "${PN}-server"
+SYSTEMD_USER_SERVICE_${PN}-server = "pulseaudio.service pulseaudio.socket"

I think specifying "pulseaudio.socket" for SYSTEMD_USER_SERVICE_${PN}-server should be enough, systemd.bbclass is going to add the .service file afair.
 

Add both:
chenqi@pek-hostel-deb01:~/poky/build-systemd [1] $ ls tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/rootfs/etc/systemd/user
default.target.wants  sockets.target.wants

Add pulseaudio.socket:
chenqi@pek-hostel-deb01:~/poky/build-systemd [1] $ ls tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/rootfs/etc/systemd/user
sockets.target.wants

They have different results.
I don't know a lot about pulseaudio. Can you confirm that pulseaudio.socket is enough?

Regards,
Chen Qi

 FILES_${PN}-misc = "${bindir}/* ${libdir}/pulseaudio/libpulsedsp.so"

--
1.9.1

--
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


--------------050606000108010605060503--