Re: [PATCH 1/1] toolchain-script: use immediate expansion for TOOLCHAIN_CONFIGSITE_NOCACHE

[ChenQi <Qi.Chen@windriver.com>]

On 09/23/2016 10:37 PM, Richard Purdie wrote:
> On Fri, 2016-09-23 at 16:30 +0800, Chen Qi wrote:
>> Use immediate expansion for the assignment to avoid other classes
>> modifying
>> variables like HOST_ARCH which changes the result. This happens in
>> the
>> meta-environment recipe. It inherits cross-canadian which changes
>> HOST_ARCH
>> from TARGET_ARCH to SDK_ARCH, resulting in wrong site config files in
>> the
>> generated SDK.
>>
>> [YOCTO #10255]
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>>   meta/classes/toolchain-scripts.bbclass | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> I've not merged this as yet since I worry that this is something we'd
> easily break again. It all depends which order classes are included and
> moving the cross-canadian inherit in meta-environment would break this
> even with immediate expansion.
>
> I think the best way to fix this might be to change the meta-
> environment to add:
>
> # Need to expand here before cross-candian changes HOST_ARCH -> SDK_ARCH
> TOOLCHAIN_CONFIGSITE_NOCACHE := "${TOOLCHAIN_CONFIGSITE_NOCACHE}"
>
> before it inherits cross-candian, then the problem is explicitly
> recorded and worked around.
>
> Cheers,
>
> Richard
>

Thanks a lot.
I've verified this solution.
A new patch has been sent out.

Best Regards,
Chen Qi