From: "Aníbal Limón" <anibal.limon@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Cc: joshua.g.lock@intel.com, clarson@kergoth.com
Subject: Re: [PATCH] classes/sstate.bbclass: Enable thread lock when checkstatus
Date: Tue, 4 Oct 2016 11:46:58 -0500 [thread overview]
Message-ID: <57F3DD02.4090300@linux.intel.com> (raw)
In-Reply-To: <1475599553-21057-1-git-send-email-anibal.limon@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]
This patch depends on bitbake one,
http://lists.openembedded.org/pipermail/bitbake-devel/2016-October/008129.html
Cheers,
alimon
On 10/04/2016 11:45 AM, Aníbal Limón wrote:
> The checkstatus function fires an event to notify bitbake UI about
> the progress of the task, this function is implemented using ThreadPool
> and is causing event lose when multiple threads tries to fire an event
> (writes over socket/fd).
>
> [YOCTO #10330]
>
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
> meta/classes/sstate.bbclass | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
> index 6f0c791..172384b 100644
> --- a/meta/classes/sstate.bbclass
> +++ b/meta/classes/sstate.bbclass
> @@ -851,15 +851,19 @@ def sstate_checkhashes(sq_fn, sq_task, sq_hash, sq_hashfn, d, siginfo=False):
>
> if tasklist:
> bb.event.fire(bb.event.ProcessStarted("Checking sstate mirror object availability", len(tasklist)), d)
> +
> import multiprocessing
> nproc = min(multiprocessing.cpu_count(), len(tasklist))
>
> + bb.event.enable_threadlock()
> pool = oe.utils.ThreadedPool(nproc, len(tasklist),
> worker_init=checkstatus_init, worker_end=checkstatus_end)
> for t in tasklist:
> pool.add_task(checkstatus, t)
> pool.start()
> pool.wait_completion()
> + bb.event.disable_threadlock()
> +
> bb.event.fire(bb.event.ProcessFinished("Checking sstate mirror object availability"), d)
> if whitelist and missing:
> bb.fatal('Required artifacts were unavailable - exiting')
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2016-10-04 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 16:45 [PATCH] classes/sstate.bbclass: Enable thread lock when checkstatus Aníbal Limón
2016-10-04 16:46 ` Aníbal Limón [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57F3DD02.4090300@linux.intel.com \
--to=anibal.limon@linux.intel.com \
--cc=clarson@kergoth.com \
--cc=joshua.g.lock@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox