From: Kang Kai <Kai.Kang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] gcc-sanitizers: allow empty for lsan and tsan packages
Date: Fri, 14 Oct 2016 17:02:59 +0800 [thread overview]
Message-ID: <58009F43.6070904@windriver.com> (raw)
In-Reply-To: <CAJTo0LaFVw6oUW5jL7kR-B3TWenNwowGRzcG8=5K=CGqPFx+5w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1294 bytes --]
On 2016年10月13日 22:59, Burton, Ross wrote:
>
> On 13 October 2016 at 15:40, Kang Kai <Kai.Kang@windriver.com
> <mailto:Kai.Kang@windriver.com>> wrote:
>
> gcc checks tsan and lsan support in source file
> gcc/libsanitizer/configure.tgt, it seems only support x86_64. Then
> tsan and lsan related packages will be empty for other target.
> For qemuarm project, add in local.conf:
>
> IMAGE_INSTALL_append = " libtsan"
>
>
> If libtsan is x86-64 only, why not only add it for x86-64 images? The
> package not existing on machines it can't be built for is more obvious
> than existing but being empty.
The real scenario is for x86-64 kernel with x86 rootfs. We created a
template to enable gcc sanitize support. It just simple adds sanitize
related packages to image:
LIBX_DEV ?= ""
LIBX_DEV_x86-64 = "liblsan-dev libtsan-dev"
IMAGE_INSTALL += " \
gcc-sanitizers \
libasan-dev \
libubsan-dev \
${LIBX_DEV} \
"
When multilib is enabled, it fails for x86-64 kernel with x86 rootfs
such as lib32-xxx-image on qemux86-64. Var IMAGE_INSTALL will be expand
with prefix lib32 but lib32-lsan* and lib32-tsan* are empty then cause
the failures.
Regards,
Kai
>
> Ross
--
Regards,
Neil | Kai Kang
[-- Attachment #2: Type: text/html, Size: 2997 bytes --]
next prev parent reply other threads:[~2016-10-14 9:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 2:37 [PATCH] gcc-sanitizers: allow empty for lsan and tsan packages kai.kang
2016-10-12 9:26 ` Burton, Ross
2016-10-13 14:40 ` Kang Kai
2016-10-13 14:59 ` Burton, Ross
2016-10-14 9:02 ` Kang Kai [this message]
2016-10-14 9:32 ` Khem Raj
2016-10-17 5:52 ` Kang Kai
2016-10-17 13:29 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58009F43.6070904@windriver.com \
--to=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox