Re: [PATCH 2/2] scripts: Add yocto-compat-layer-wrapper

["Aníbal Limón" <anibal.limon@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2065 bytes --]

Sending to oe-core ml, i used wrong oe-core mail address, :/,

	Anibal



On 03/30/2017 10:03 AM, Aníbal Limón wrote:
> 
> 
> On 03/30/2017 12:02 AM, Patrick Ohly wrote:
>> On Wed, 2017-03-29 at 15:44 -0600, Aníbal Limón wrote:
>> ...
>>> +show_help() {
>>> +	printf "Usage: %s [-o output_log] [-h] LAYER_DIR ...\n" $0
>>> +}
>>> +
>> ...
>>> +env_dir=$(mktemp -d -t yocto-compat-XXXX)
>>> +echo "The environment will be setup at $env_dir"
>>> +echo ""
>>
>> The directory gets created, but not removed.
> 
> I didn't remove the temp directory because may be the user wants to
> access the dir after the check.
> 
>>
>>> +echo "Cloning oe-core..."
>>> +git clone $oe_core_repo $env_dir
>>> +if [ $? -ne 0 ]; then
>>> +	echo "Failed to clone oe-core repository"
>>> +	exit 1
>>> +fi
>>> +
>>> +echo "Cloning bitbake..."
>>> +git clone $bitbake_repo $env_dir/bitbake
>>> +if [ $? -ne 0 ]; then
>>> +	echo "Failed to clone bitbake repository"
>>> +	exit 1
>>> +fi
>>
>> Cloning bitbake and OE-core each time the script runs will be fairly
>> slow. There's also a chicken-and-egg problem: if you don't have bitbake,
>> where's the script?
>>
>> I'd prefer to use an existing checkout of both, just as for the layers
>> which are to be tested.
> 
> I choose to clone the oe-core/bitbake to ensure there are a clean
> environment, without any previous layer added. I could add an option to
> specify a oe-core/bitbake dir if isn't set then clone.
> 
>>
>>> +cd $env_dir
>>> +source oe-init-build-env
>>> +if [[ -z $output_log ]]; then
>>> +	echo "Running yocto-compat-layer.py $layer_dirs"
>>> +	yocto-compat-layer.py $layer_dirs
>>> +else
>>> +	echo "Running yocto-compat-layer.py -o $output_log $layer_dirs"
>>> +	yocto-compat-layer.py -o $output_log $layer_dirs
>>> +fi
>>
>> It would be useful to accept and pass through all yocto-compat-layer.py
>> parameters, ideally without having to repeat a full list of them in the
>> argument parsing of the wrapper.
> 
> Agree,
> 
> 	Anibal
>>
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]