public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: michael@rndt.dev, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] sstate: Add fallback when hardlink fails
Date: Wed, 15 Apr 2026 10:29:34 +0100	[thread overview]
Message-ID: <58af6d456e153cfd7810fc48a199d170a592f2f1.camel@linuxfoundation.org> (raw)
In-Reply-To: <20260415085824.1730569-1-michael@rndt.dev>

On Wed, 2026-04-15 at 10:58 +0200, Michael Arndt via lists.openembedded.org wrote:
> Previously the sstate didn't work on file systems that don't support hardlinks.
> For example when using WebDAV to share the sstate. This change avoids the
> problem by adding a fallback in case the hardlink fails.
> 
> Signed-off-by: Michael Arndt <michael@rndt.dev>
> ---
>  meta/classes-global/sstate.bbclass | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

The change makes it unconditionally overwrite the file in the case of
any failure. This totally breaks the point of the existing code :(.

The challenge is that the sstate directory is shared, so two builds can
write to the same file at the same time. Our policy is "first wins" and
anything later is just skipped. The code also needs to make sure that
if the sstate file is written, the paired signature matches.

I appreciate the issue you're trying to solve but this isn't the right
fix. Generic try/except cases are almost always a red flag in general.

Cheers,

Richard


  reply	other threads:[~2026-04-15  9:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15  8:58 [PATCH] sstate: Add fallback when hardlink fails Michael Arndt
2026-04-15  9:29 ` Richard Purdie [this message]
2026-04-15 11:52   ` [OE-core] " Michael Arndt
2026-04-15 13:07     ` Richard Purdie
2026-04-15 14:43       ` Michael Arndt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=58af6d456e153cfd7810fc48a199d170a592f2f1.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=michael@rndt.dev \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox