Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Andrej Valek <andrej.valek@siemens.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] feat(openssl-1.1): rework packaging
Date: Thu, 7 Jun 2018 16:13:13 +0300	[thread overview]
Message-ID: <59452b23-7470-588c-75fb-7445aaa13ba1@linux.intel.com> (raw)
In-Reply-To: <20180607073209.27240-1-andrej.valek@siemens.com>

On 06/07/2018 10:32 AM, Andrej Valek wrote:
> -do_install_append_class-native () {
>           # Install a custom version of c_rehash that can handle sysroots properly.
>           # This version is used for example when installing ca-certificates during
>           # image creation.
>           install -Dm 0755 ${WORKDIR}/openssl-c_rehash.sh ${D}${bindir}/c_rehash
>           sed -i -e 's,/etc/openssl,${sysconfdir}/ssl,g' ${D}${bindir}/c_rehash

Why is this merged into the main do_install()? Please explain.

> +        # Create SSL structure
> +        install -d ${D}${sysconfdir}/ssl/
> +        mv ${D}${libdir}/ssl-1.1/openssl.cnf \
> +           ${D}${libdir}/ssl-1.1/certs \
> +           ${D}${libdir}/ssl-1.1/private \
> +           \
> +           ${D}${sysconfdir}/ssl/
> +        ln -sf ${sysconfdir}/ssl/certs ${D}${libdir}/ssl-1.1/certs
> +        ln -sf ${sysconfdir}/ssl/private ${D}${libdir}/ssl-1.1/private
> +        ln -sf ${sysconfdir}/ssl/openssl.cnf ${D}${libdir}/ssl-1.1/openssl.cnf

Please explain this change as well. Resend the patch with the 
explanations included in the commit log or (better), the recipe itself.

I would like to keep the new openssl recipe short and simple, and so 
anything that adds lines and complication should be well justified. :)

Alex


  reply	other threads:[~2018-06-07 13:12 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-07  7:25 [PATCH] feat(openssl-1.1): rework packaging Andrej Valek
2018-06-07  7:32 ` [PATCH v2] " Andrej Valek
2018-06-07 13:13   ` Alexander Kanavin [this message]
2018-06-07 13:26     ` Alexander Kanavin
2018-06-08  6:33     ` Andrej Valek
2018-06-08  7:48       ` Andrej Valek
2018-06-08  9:48         ` Alexander Kanavin
2018-06-08 11:31           ` Andrej Valek
2018-06-08 11:47             ` Alexander Kanavin
2018-06-08 14:04               ` [PATCH v3 1/2] openssl-1.1: " Andrej Valek
2018-06-08 15:57                 ` Alexander Kanavin
2018-06-11  6:19                   ` Andrej Valek
2018-06-11 12:45                     ` Alexander Kanavin
2018-06-11 17:54                       ` Peter Kjellerstedt
2018-06-11 18:15                         ` Alexander Kanavin
2018-06-11 13:30                 ` [PATCH v4 1/3] openssl-1.1: fix c_rehash perl errors Andrej Valek
2018-06-11 13:30                 ` [PATCH v4 2/3] openssl-1.1: rework packaging Andrej Valek
2018-06-11 13:30                 ` [PATCH v4 3/3] openssl-1.1: /etc/ssl location compatibility Andrej Valek
2018-07-09 12:06                   ` Andrej Valek
2018-07-09 12:44                     ` Alexander Kanavin
2018-06-08 14:04               ` [PATCH v3 2/2] " Andrej Valek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59452b23-7470-588c-75fb-7445aaa13ba1@linux.intel.com \
    --to=alexander.kanavin@linux.intel.com \
    --cc=andrej.valek@siemens.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox