Re: [PATCH] pango: fix ptest failed problem

[Peter Kjellerstedt <peter.kjellerstedt@axis.com>]

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org <openembedded-
> core-bounces@lists.openembedded.org> On Behalf Of
> changqing.li@windriver.com
> Sent: den 30 september 2018 04:00
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH] pango: fix ptest failed problem
> 
> From: Changqing Li <changqing.li@windriver.com>
> 
> disable-debug will cause compiling with G_DISABLE_ASSERT, but ptest
> need
> it, so don't disable-debug when ptest is enabled.
> 
> ptest fail error:
> 
> Tests were compiled with G_DISABLE_ASSERT and are likely no-ops.
> Aborting.
> FAIL: pango/test-font.test (Child process exited with code 1)
> Running test: pango/testboundaries_ucd.test
> Tests were compiled with G_DISABLE_ASSERT and are likely no-ops.
> Aborting.
> FAIL: pango/testboundaries_ucd.test (Child process exited with code 1)
> Running test: pango/testboundaries.test
> Tests were compiled with G_DISABLE_ASSERT and are likely no-ops.
> Aborting.
> FAIL: pango/testboundaries.test (Child process exited with code 1)
> Running test: pango/testattributes.test
> Tests were compiled with G_DISABLE_ASSERT and are likely no-ops.
> Aborting.
> 
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
>  meta/recipes-graphics/pango/pango_1.42.4.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-graphics/pango/pango_1.42.4.bb
> b/meta/recipes-graphics/pango/pango_1.42.4.bb
> index e73fd28..c680720 100644
> --- a/meta/recipes-graphics/pango/pango_1.42.4.bb
> +++ b/meta/recipes-graphics/pango/pango_1.42.4.bb
> @@ -24,7 +24,7 @@ DEPENDS = "glib-2.0 glib-2.0-native fontconfig freetype virtual/libiconv cairo h
>  PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)}"
>  PACKAGECONFIG[x11] = "--with-xft,--without-xft,virtual/libx11 libxft"
> 
> -EXTRA_OECONF = "--disable-debug"
> +EXTRA_OECONF = "${@bb.utils.contains('DISTRO_FEATURES', 'ptest',"","--disable-debug",d)}"

The above can be written cleaner as:

PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'ptest x11', d)}"
PACKAGECONFIG[ptest] = "--enable-debug,--disable-debug"
PACKAGECONFIG[x11] = "--with-xft,--without-xft,virtual/libx11 libxft"

(I added the --enable-debug to the ptest PACKAGECONFIG for symmetry, 
even though I assume it is the default.)

>  LEAD_SONAME = "libpango-1.0*"
>  LIBV = "1.8.0"
> --
> 2.7.4

//Peter