Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Yu, Mingli" <mingli.yu@windriver.com>
To: <richard.purdie@linuxfoundation.org>, <ross.burton@intel.com>,
	<raj.khem@gmail.com>, <randy.macleod@windriver.com>,
	<alejandro.enedino.hernandez-samaniego@xilinx.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v3] python: add tk support
Date: Mon, 19 Nov 2018 09:31:36 +0800	[thread overview]
Message-ID: <5BF21278.5000503@windriver.com> (raw)
In-Reply-To: <1542188296-116872-1-git-send-email-mingli.yu@windriver.com>

Ping.

Thanks,

On 2018年11月14日 17:38, mingli.yu@windriver.com wrote:
> From: Mingli Yu <Mingli.Yu@windriver.com>
>
> Add support to enable tk via PACKGECONFIG.
> before the patch:
>   # python
>   Python 2.7.15 (default, Nov  8 2018, 04:53:50)
>   [GCC 8.2.0] on linux2
>   Type "help", "copyright", "credits" or "license" for more information.
>   >>> import Tkinter
>   Traceback (most recent call last):
>    File "<stdin>", line 1, in <module>
>    File "/usr/lib64/python2.7/lib-tk/Tkinter.py", line 39, in <module>
>      import _tkinter # If this fails your Python may not be configured for Tk
>   ImportError: No module named _tkinter
>   >>>
>
> After the patch, if enable tk in PACKGECONFIG, then
>   # python
>   Python 2.7.15 (default, Oct 25 2018, 08:12:45)
>   [GCC 8.2.0] on linux2
>   Type "help", "copyright", "credits" or "license" for more information.
>   >>> import Tkinter
>   >>>
>
> Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
> ---
>   meta/recipes-devtools/python/python/python2-manifest.json | 3 ++-
>   meta/recipes-devtools/python/python_2.7.15.bb             | 5 +++--
>   2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-devtools/python/python/python2-manifest.json b/meta/recipes-devtools/python/python/python2-manifest.json
> index 260fa6f..a9f3924 100644
> --- a/meta/recipes-devtools/python/python/python2-manifest.json
> +++ b/meta/recipes-devtools/python/python/python2-manifest.json
> @@ -966,6 +966,7 @@
>               "core"
>           ],
>           "files": [
> +            "${libdir}/python${PYTHON_MAJMIN}/lib-dynload/_tkinter.so",
>               "${libdir}/python2.7/lib-tk"
>           ]
>       },
> @@ -1043,4 +1044,4 @@
>               "${libdir}/python2.7/lib-dynload/zlib.so"
>           ]
>       }
> -}
> \ No newline at end of file
> +}
> diff --git a/meta/recipes-devtools/python/python_2.7.15.bb b/meta/recipes-devtools/python/python_2.7.15.bb
> index dd969d8..6a60aa7 100644
> --- a/meta/recipes-devtools/python/python_2.7.15.bb
> +++ b/meta/recipes-devtools/python/python_2.7.15.bb
> @@ -21,7 +21,7 @@ SRC_URI += "\
>     file://setuptweaks.patch \
>     file://check-if-target-is-64b-not-host.patch \
>     file://search_db_h_in_inc_dirs_and_avoid_warning.patch \
> -  file://avoid_warning_about_tkinter.patch \
> +  ${@bb.utils.contains('PACKAGECONFIG', 'tk', '', 'file://avoid_warning_about_tkinter.patch', d)} \
>     file://avoid_warning_for_sunos_specific_module.patch \
>     file://python-2.7.3-remove-bsdb-rpath.patch \
>     file://run-ptest \
> @@ -45,6 +45,7 @@ EXTRA_OECONF += "ac_cv_file__dev_ptmx=yes ac_cv_file__dev_ptc=no"
>
>   PACKAGECONFIG ??= "bdb"
>   PACKAGECONFIG[bdb] = ",,db"
> +PACKAGECONFIG[tk] = ",,tk"
>
>   do_configure_append() {
>   	rm -f ${S}/Makefile.orig
> @@ -172,7 +173,7 @@ RDEPENDS_${PN}-modules += "${PN}-misc"
>
>   # ptest
>   RDEPENDS_${PN}-ptest = "${PN}-modules ${PN}-tests unzip"
> -
> +RDEPENDS_${PN}-tkinter += "${@bb.utils.contains('PACKAGECONFIG', 'tk', 'tk', '', d)}"
>   # catch manpage
>   PACKAGES += "${PN}-man"
>   FILES_${PN}-man = "${datadir}/man"
>


  reply	other threads:[~2018-11-19  1:33 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08  6:08 [PATCH v2 0/7] python/python3: add tk support mingli.yu
2018-11-08  6:08 ` [PATCH v2 1/7] python: " mingli.yu
2018-11-14  9:38   ` [PATCH v3] " mingli.yu
2018-11-19  1:31     ` Yu, Mingli [this message]
2018-11-23  1:30     ` Yu, Mingli
2018-11-08  6:08 ` [PATCH 2/7] python3: " mingli.yu
2018-11-08 13:49   ` Burton, Ross
2018-11-09  1:38     ` Yu, Mingli
2018-11-09 13:02       ` Burton, Ross
2018-11-12  2:28         ` Yu, Mingli
2018-11-12 15:28           ` Alejandro Hernandez
2018-11-13  3:03             ` Yu, Mingli
2018-11-13  8:25               ` Alejandro Hernandez
2018-11-13  9:10                 ` Yu, Mingli
2018-11-13 21:26                   ` Alejandro Hernandez
2018-11-14  8:23                     ` Yu, Mingli
2018-11-14  9:36   ` [PATCH v2] " mingli.yu
2018-11-19  1:32     ` Yu, Mingli
2018-11-23  1:29     ` Yu, Mingli
2018-11-23 11:03       ` richard.purdie
2018-11-23 11:14         ` Richard Purdie
2018-11-08  6:08 ` [PATCH 3/7] libxt: extend to nativesdk mingli.yu
2018-11-08  6:08 ` [PATCH 4/7] libxft: " mingli.yu
2018-11-08  6:08 ` [PATCH 5/7] fontconfig: " mingli.yu
2018-11-08  6:08 ` [PATCH 6/7] libsm: " mingli.yu
2018-11-08  6:08 ` [PATCH 7/7] libice: " mingli.yu
2018-11-08  6:12 ` [PATCH v2 0/7] python/python3: add tk support mingli.yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BF21278.5000503@windriver.com \
    --to=mingli.yu@windriver.com \
    --cc=alejandro.enedino.hernandez-samaniego@xilinx.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=randy.macleod@windriver.com \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox