From: "Yu, Mingli" <mingli.yu@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] asciidoc: disable xmllint check
Date: Thu, 4 Apr 2019 16:28:15 +0800 [thread overview]
Message-ID: <5CA5C01F.1050303@windriver.com> (raw)
In-Reply-To: <CAJTo0Lak05SBbDApK4L-QZpSqR_cONECVhDUUq99B_JFFhgVbQ@mail.gmail.com>
On 2019年04月04日 16:02, Burton, Ross wrote:
> Some further context (note to self: don't reply to mails during
> breakfast): the problem which lead to xmllint failing also leads to
> the XSL stylesheets in the sysroot not being used, so xsltproc
> downloads them. On my machine, asciidoc should execute do_compile in
> about a second, but with the broken catalogues this was taking almost
> a minute.
Thanks Ross's reminding.
Thanks,
>
> Ross
>
> On Thu, 4 Apr 2019 at 08:30, Burton, Ross <ross.burton@intel.com> wrote:
>>
>> I've submitted fixes for this already.
>>
>> Ross
>>
>> On Thu, 4 Apr 2019 at 07:12, <mingli.yu@windriver.com> wrote:
>>>
>>> From: Mingli Yu <Mingli.Yu@windriver.com>
>>>
>>> asciidoc-native build with below error when
>>> there is no xmllint program located on build
>>> host:
>>> | python3 a2x.py -f manpage doc/asciidoc.1.txt
>>> | a2x: ERROR: "xmllint" --nonet --noout --valid "/build/tmp/work/x86_64-linux/asciidoc-native/8.6.9+py3-gitAUTOINC+618f6e6f6b-r0/git/doc/asciidoc.1.xml" returned non-zero exit status 4
>>> |
>>> | Makefile:110: recipe for target 'doc/asciidoc.1' failed
>>>
>>> Considering it's only used to check the xml format
>>> of the doc file as doc/asciidoc.1.txt, so disable
>>> xmllint check to fix the above issue.
>>>
>>> Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
>>> ---
>>> meta/recipes-extended/asciidoc/asciidoc_8.6.9.bb | 4 ++-
>>> .../0001-Makefile.in-disable-xmllint-check.patch | 38 ++++++++++++++++++++++
>>> 2 files changed, 41 insertions(+), 1 deletion(-)
>>> create mode 100644 meta/recipes-extended/asciidoc/files/0001-Makefile.in-disable-xmllint-check.patch
>>>
>>> diff --git a/meta/recipes-extended/asciidoc/asciidoc_8.6.9.bb b/meta/recipes-extended/asciidoc/asciidoc_8.6.9.bb
>>> index d0d1517..7e00b34 100644
>>> --- a/meta/recipes-extended/asciidoc/asciidoc_8.6.9.bb
>>> +++ b/meta/recipes-extended/asciidoc/asciidoc_8.6.9.bb
>>> @@ -8,7 +8,9 @@ LICENSE = "GPLv2"
>>> LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b \
>>> file://COPYRIGHT;md5=029ad5428ba5efa20176b396222d4069"
>>>
>>> -SRC_URI = "git://github.com/asciidoc/asciidoc-py3;protocol=https"
>>> +SRC_URI = "git://github.com/asciidoc/asciidoc-py3;protocol=https \
>>> + file://0001-Makefile.in-disable-xmllint-check.patch \
>>> +"
>>> SRCREV = "618f6e6f6b558ed1e5f2588cd60a5a6b4f881ca0"
>>> PV .= "+py3-git${SRCPV}"
>>>
>>> diff --git a/meta/recipes-extended/asciidoc/files/0001-Makefile.in-disable-xmllint-check.patch b/meta/recipes-extended/asciidoc/files/0001-Makefile.in-disable-xmllint-check.patch
>>> new file mode 100644
>>> index 0000000..4c0dd6d
>>> --- /dev/null
>>> +++ b/meta/recipes-extended/asciidoc/files/0001-Makefile.in-disable-xmllint-check.patch
>>> @@ -0,0 +1,38 @@
>>> +From 242e58f16c129f5983d6b32d493619cc4f87703e Mon Sep 17 00:00:00 2001
>>> +From: Mingli Yu <Mingli.Yu@windriver.com>
>>> +Date: Thu, 4 Apr 2019 13:38:10 +0800
>>> +Subject: [PATCH] Makefile.in: disable xmllint check
>>> +
>>> +asciidoc-native build with below error when
>>> +there is no xmllint program located on build
>>> +host:
>>> +| python3 a2x.py -f manpage doc/asciidoc.1.txt
>>> +| a2x: ERROR: "xmllint" --nonet --noout --valid "/build/tmp/work/x86_64-linux/asciidoc-native/8.6.9+py3-gitAUTOINC+618f6e6f6b-r0/git/doc/asciidoc.1.xml" returned non-zero exit status 4
>>> +|
>>> +| Makefile:110: recipe for target 'doc/asciidoc.1' failed
>>> +
>>> +So disable xmllint check to fix the above issue.
>>> +
>>> +Upstream-Status: Inappropriate [oe build specific]
>>> +
>>> +Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
>>> +---
>>> + Makefile.in | 2 +-
>>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>>> +
>>> +diff --git a/Makefile.in b/Makefile.in
>>> +index ffba3b5..fb95fab 100644
>>> +--- a/Makefile.in
>>> ++++ b/Makefile.in
>>> +@@ -107,7 +107,7 @@ $(DATATARGETS): % : %dir
>>> + $(INSTALL_DATA) $($@) $(DESTDIR)/$($<)/
>>> +
>>> + $(manp): %.1 : %.1.txt
>>> +- python3 a2x.py -f manpage $<
>>> ++ python3 a2x.py -L -f manpage $<
>>> +
>>> + docs:
>>> + $(INSTALL) -d $(DESTDIR)/$(docdir)
>>> +--
>>> +2.7.4
>>> +
>>> --
>>> 2.7.4
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
prev parent reply other threads:[~2019-04-04 8:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 6:11 [PATCH] asciidoc: disable xmllint check mingli.yu
2019-04-04 7:30 ` Burton, Ross
2019-04-04 8:02 ` Burton, Ross
2019-04-04 8:28 ` Yu, Mingli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CA5C01F.1050303@windriver.com \
--to=mingli.yu@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox