Re: [PATCH v3] nettle: fix ptest failure

["Yu, Mingli" <mingli.yu@windriver.com>]

On 2019年04月15日 19:08, richard.purdie@linuxfoundation.org wrote:
> On Mon, 2019-04-15 at 17:05 +0800, mingli.yu@windriver.com wrote:
>> @@ -33,6 +29,8 @@ EXTRA_OECONF = "--disable-openssl"
>>   CFLAGS_append = " -std=c99"
>>
>>   do_compile_ptest() {
>> +        # fix dlopen-test failure as cannot locate libnettle.so
>> +        sed -i 's;dlopen ("../libnettle.so", RTLD_NOW);dlopen
>> ("${libdir}/libnettle.so", RTLD_NOW);g' ${S}/testsuite/dlopen-test.c
>>           oe_runmake buildtest
>>   }
>>
>> @@ -49,4 +47,7 @@ do_install_ptest() {
>>           install ${B}/testsuite/*-test ${D}${PTEST_PATH}/testsuite/
>>   }
>>
>> +RDEPENDS_${PN}-ptest += "${PN}-dev"
>> +INSANE_SKIP_${PN}-ptest += "dev-deps"
>> +
>>   BBCLASSEXTEND = "native nativesdk"
>
> Does Adrian's suggestion of removing the "../" work? Also, can we

Yes, the Adrian's suggestion works. But I think it's also okay to update 
the actual libnettle.so path in do_compile_ptest phase as we still need 
an extra patch if use Adrian's suggestion.

> install a symlink in do_install_ptest which this code would find? That

Install a symlink? Does it means nettle-ptest will provide libnettle.so?
@@ -45,6 +49,7 @@ do_install_ptest() {
          # tools can be found in PATH, not in ../tools/
          sed -i -e 's|../tools/||' ${D}${PTEST_PATH}/testsuite/*-test
          install ${B}/testsuite/*-test ${D}${PTEST_PATH}/testsuite/
+        ln -s ${libdir}/libnettle.so.6.5 ${D}${PTEST_PATH}/libnettle.so
  }


> would be less invasive and we could potentially remove the -dev package
> dependency which would be good from an image perspective.

Just nettle-ptest rdepends on nettle-dev.

>
> Cheers,
>
> Richard
>
>