Re: [PATCH] glib-2.0: fix ptest failures

["Yu, Mingli" <mingli.yu@windriver.com>]

On 2019年04月23日 23:52, Burton, Ross wrote:
> On Fri, 19 Apr 2019 at 09:54, <mingli.yu@windriver.com> wrote:
>> From: Mingli Yu <Mingli.Yu@windriver.com>
>>
>> * Set G_TEST_BUILDDIR to mark we run the tests
>>    out of builddir to make it can skip the test_non_utf8_printf
>>    to fix below test error as test_non_utf8_printf needed
>>    to run under builddir per https://gitlab.gnome.org/GNOME/glib/blob/master/glib/tests/gdatetime.c#L1440.
>>    | GLib:ERROR:../glib-2.58.3/glib/tests/gdatetime.c:1477:test_non_utf8_printf: assertion failed (__p == ("10\346\234\210")): ("Oct" == "10\346\234\210")
>>    | Bail out! GLib:ERROR:../glib-2.58.3/glib/tests/gdatetime.c:1477:test_non_utf8_printf: assertion failed (__p == ("10\346\234\210")): ("Oct" == "10\346\234\210")
>>    | FAIL: glib/gdatetime.test (Child process killed by signal 6)
>
> As per the link:
>
> /* If running uninstalled (G_TEST_BUILDDIR is set), skip this test, since we
>     * need the translations to be installed. We can’t mess around with
>     * bindtextdomain() here, as the compiled .gmo files in po/ are not in the
>     * right installed directory hierarchy to be successfully loaded by
> gettext. */
>
> Setting G_TEST_BUILDDIR isn't right as we're not running uninstalled.
> This is a gross hack, and not a fix.

Per the comments at https://gitlab.gnome.org/GNOME/glib/issues/1357, we 
need to run test_non_utf8_printf under builddir to guarantee the test 
passed.

Thanks,

>
> Ross
>