Re: [OE-Core][PATCH 1/3] eudev: Convert dependencies to PACKAGECONFIG

[richard.purdie@linuxfoundation.org]

On Mon, 2022-05-16 at 20:49 +0100, Alex Kiernan wrote:
> GObject support was dropped in 252150e181c5 ("src/gudev: remove Gobject
> libudev support."), but some gir support appears to still exist.
> 
> Fill out PACKAGECONFIG options.
> 
> Signed-off-by: Alex Kiernan <alexk@zuma.ai>
> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
> ---
>  meta/recipes-core/udev/eudev_3.2.11.bb | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-core/udev/eudev_3.2.11.bb b/meta/recipes-core/udev/eudev_3.2.11.bb
> index 841039f6d745..0fd1b6ab2283 100644
> --- a/meta/recipes-core/udev/eudev_3.2.11.bb
> +++ b/meta/recipes-core/udev/eudev_3.2.11.bb
> @@ -5,7 +5,7 @@ LICENSE = "GPL-2.0-or-later & LGPL-2.1-or-later"
>  LICENSE:libudev = "LGPL-2.1-or-later"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>  
> -DEPENDS = "glib-2.0 glib-2.0-native gperf-native kmod util-linux"
> +DEPENDS = "gperf-native"
>  
>  PROVIDES = "udev"
>  
> @@ -19,7 +19,7 @@ SRC_URI[sha256sum] = "19847cafec67897da855fde56f9dc7d92e21c50e450aa79068a7e704ed
>  UPSTREAM_CHECK_URI = "https://github.com/eudev-project/eudev/releases"
>  UPSTREAM_CHECK_REGEX = "eudev-(?P<pver>\d+(\.\d+)+)\.tar"
>  
> -inherit autotools update-rc.d qemu pkgconfig features_check manpages
> +inherit autotools update-rc.d qemu pkgconfig features_check manpages gobject-introspection

I like most of what this patch does, cleaning up this kind of thing is
great. I am a bit worried about the gobject-introspection inherit
though as this wasn't there before and brings with it a huge dependency
tree. For something as "core" as udev that is rather sad. Do we really
need it? Should we find a way to disable it by default?

Cheers,

Richard