Re: [OE-core] [PATCH v2 3/3] systemd: Build the systemctl executable

[Vyacheslav Yurkov <uvv.mail@gmail.com>]

On 04.02.2025 14:18, Mikko Rapeli wrote:
> Hmm, doesn't this overwrite SRC_URI from systemd.inc?
>
> SRC_URI += "file://...patch" would amend the patch file.

Good catch!

>> -S = "${WORKDIR}/sources"
>> -UNPACKDIR = "${S}"
>> -
>> -do_install() {
>> -	install -d ${D}${bindir}
>> -	install -m 0755 ${S}/systemctl ${D}${bindir}
>> -}
>> +MESON_TARGET = "systemctl:executable"
>> +MESON_INSTALL_TAGS = "systemctl"
>> +EXTRA_OEMESON:append = " -Dlink-systemctl-shared=false"
> I wonder why this tag support is needed since MESON_TARGET already
> compiles only the correct executable with static linking. Is it there
> just to let meson handle the install step of a single systemctl
> executable?
>
> Or does it install more files, like config files too?

Correct. It installs much more when no tags specified :)

>
> I'm comparing this to a draft systemd-boot-native recipe for ukify
> which I had and which sets the build target but installs manually:
>
> MESON_TARGET = "ukify"
>
> EXTRA_OEMESON += "-Dnobody-user=nobody \
>      -Dnobody-group=nogroup \
>      -Drootlibdir=${rootlibdir} \
>      -Drootprefix=${rootprefix} \
>      -Ddefault-locale=C \
>      -Dmode=release \
>      -Dsystem-alloc-uid-min=101 \
>      -Dsystem-uid-max=999 \
>      -Dsystem-alloc-gid-min=101 \
>      -Dsystem-gid-max=999 \
> "
>
> do_install() {
>      install -d ${D}${bindir}/
>      install -m 0755 ${S}/src/ukify/ukify.py ${D}${bindir}/ukify
> }
>
> So the custom do_install() step could be avoided if systemd meson config
> would have "install_tag" for ukify too?

Correct. There's more discussion here 
https://github.com/systemd/systemd/pull/36243 , but if we need more 
tags, they can be added.

>
> Current systemd-boot-native recipe installs/copies the unmodified ukify.py
> from source tree and uses that in native. It doesn't run meson build for it
> and thus things like version details are incorrect. Also some additional tools
> like systemd-measure, systemd-sbsign etc are not compiled so some usecases may
> not be supported atm. If those would also include the install tags, then they
> could be compiled and installed too, I presume.

Yes, that would be an option as well

Slava